fix(client): treat empty OPENAI_BASE_URL env var as unset#3275
Open
rmotgi1227 wants to merge 1 commit into
Open
fix(client): treat empty OPENAI_BASE_URL env var as unset#3275rmotgi1227 wants to merge 1 commit into
rmotgi1227 wants to merge 1 commit into
Conversation
os.environ.get("OPENAI_BASE_URL") returns "" when the variable is set
but blank. The subsequent 'if base_url is None' check then skips the
default fallback, passing an empty string to httpx which raises
APIConnectionError. Change to 'if not base_url' to treat both None
and empty string as absent, falling back to the default API endpoint.
Fixes openai#2927
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2927.
Summary
When
OPENAI_BASE_URLis set to an empty string in the environment,os.environ.get("OPENAI_BASE_URL")returns"". The subsequentif base_url is Nonecheck is skipped, sobase_url = ""is passed to httpx — which raisesAPIConnectionError: Connection errorbefore any network request is made.Root cause
Fix
Change
is None→not base_urlso bothNoneand""fall back to the default:Applied to both
OpenAI.__init__(line 214) andAsyncOpenAI.__init__(line 720).