fix(tests): use "compaction" as ContextManagement type value#3265
Open
rmotgi1227 wants to merge 1 commit into
Open
fix(tests): use "compaction" as ContextManagement type value#3265rmotgi1227 wants to merge 1 commit into
rmotgi1227 wants to merge 1 commit into
Conversation
The ContextManagement TypedDict's type field only accepts "compaction" (see response_create_params.py: "Currently only 'compaction' is supported"). The auto-generated test stubs used the placeholder string "type", which is not a valid value and would never exercise the intended code path. Fixes openai#2868
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2868.
The
ContextManagementTypedDict'stypefield is documented to accept only"compaction":The auto-generated test stubs in
tests/api_resources/test_responses.pyused the placeholder string"type"in fourcontext_managementfixtures, which is not a valid value. This means the tests were constructing payloads that the API would reject, not exercising the actual accepted value.Change
tests/api_resources/test_responses.py— replace"type": "type"→"type": "compaction"at lines 35, 123, 448, and 536 (all fourcontext_managementdict literals in the sync and async test variants).Verification