fix: correct prompt_cache_retention Literal from "in-memory" to "in_memory"#2971
Open
alvinttang wants to merge 1 commit intoopenai:mainfrom
Open
fix: correct prompt_cache_retention Literal from "in-memory" to "in_memory"#2971alvinttang wants to merge 1 commit intoopenai:mainfrom
alvinttang wants to merge 1 commit intoopenai:mainfrom
Conversation
…_memory" The API expects "in_memory" (underscore) but the type definitions declared "in-memory" (hyphen), causing 400 errors when using the SDK-typed value. Fixes openai#2883 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prompt_cache_retentionLiteral type from"in-memory"(hyphen) to"in_memory"(underscore) across all 5 affected type definition files"in-memory"with a 400 error and only accepts"in_memory", so the SDK-typed value was unusable withouttype: ignoreFixes #2883
Files changed
src/openai/types/chat/completion_create_params.pysrc/openai/types/responses/response_create_params.pysrc/openai/types/responses/response.pysrc/openai/types/responses/responses_client_event_param.pysrc/openai/types/responses/responses_client_event.pyNote on code generation
These type files appear to be auto-generated from an OpenAPI spec (per
.stats.yml). The upstream OpenAPI spec should also be updated to use"in_memory"to prevent this from regressing on the next codegen run.🤖 Generated with Claude Code