fix: convert by_alias=None to bool for pydantic v2#2967
Open
Jah-yee wants to merge 1 commit intoopenai:mainfrom
Open
fix: convert by_alias=None to bool for pydantic v2#2967Jah-yee wants to merge 1 commit intoopenai:mainfrom
Jah-yee wants to merge 1 commit intoopenai:mainfrom
Conversation
When DEBUG logging is enabled, model_dump() is called with by_alias=None (the default), which causes pydantic-core's Rust serializer to raise: TypeError: argument 'by_alias': 'NoneType' object cannot be converted to 'PyBool' This fix converts None to True (pydantic's default behavior) when passing to model_dump() for pydantic v2. Fixes: openai#2965
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When DEBUG logging is enabled,
model_dump()is called withby_alias=None(the default), which causes pydantic-core Rust serializer to raise:This fix converts
NonetoTrue(pydantic default behavior) before passing tomodel_dump()for pydantic v2.Root cause: The
_compat.pyfunction signature declaresby_alias: bool | None = None, but passes it directly to pydantic v2smodel_dump()which expects a bool, not None.Fix: Convert
by_aliastoboolwhen passing to pydantic v2, defaulting toTrue(pydantic default) whenNoneis passed.Fixes: #2965