feat: add configurable HTTP client timeouts via config file#1882
Closed
piotrjanik wants to merge 1 commit intoopen-component-model:mainfrom
Closed
feat: add configurable HTTP client timeouts via config file#1882piotrjanik wants to merge 1 commit intoopen-component-model:mainfrom
piotrjanik wants to merge 1 commit intoopen-component-model:mainfrom
Conversation
github-actions
Bot
added
area/documentation
piotrjanik
force-pushed
the
feat/timeout
branch
from
e75480a to
b509b62
Compare
piotrjanik
force-pushed
the
feat/timeout
branch
from
8e071bf to
792d8f5
Compare
| ) | ||
|
|
||
| const ( | ||
| ATTR_KEY = "ocm.software/ocm/api/datacontext/attrs/httptimeout" |
Member
There was a problem hiding this comment.
nit: if this is an attribute config and not a normal config its impossible for us to use in v2, so im wondering if an attr should even be included
Contributor
Author
There was a problem hiding this comment.
@jakobmoellerdev I followed the rootcertsattr implementation and replicated it here. Why could this be a problem for v2?
Member
There was a problem hiding this comment.
because attribute configs by design are problematic in v2 due to our plugin nature so we do not support any attribtue configuration in v2 atm
Contributor
Author
There was a problem hiding this comment.
@jakobmoellerdev I have created this PR with different approach: https://github.com/open-component-model/ocm/pull/1887/changes
This one should use config file only.
Member
jakobmoellerdev
left a comment
jakobmoellerdev
left a comment
There was a problem hiding this comment.
2 nits on parsing, apart from that LGTM
Contributor
matthiasbruns
left a comment
matthiasbruns
left a comment
There was a problem hiding this comment.
lgtm now - only the nits from jakob
piotrjanik
force-pushed
the
feat/timeout
branch
2 times, most recently
from
c7fcbcc to
2ed48d4
Compare
<!-- markdownlint-disable MD041 --> Introduce the `http.config.ocm.software/v1alpha1` config type for controlling HTTP client timeouts (dial, TLS handshake, response header, idle connection, keep-alive, and overall timeout). Timeouts are configured exclusively through the OCM config file using Go duration strings. When not set, `http.DefaultTransport` values are preserved unchanged. - Add `httpcfgattr` package with Duration type - Add `api/utils/httpclient` transport factory (clones DefaultTransport, selectively overrides from config) - Wire HTTP settings into docker daemon and OCI registry clients - Add integration tests using toxiproxy for timeout verification - Update docs with new config type documentation Fixes: open-component-model#1731 Signed-off-by: Piotr Janik <piotr.janik@sap.com>
piotrjanik
force-pushed
the
feat/timeout
branch
from
2ed48d4 to
1453795
Compare
jakobmoellerdev
approved these changes
Mar 30, 2026
matthiasbruns
approved these changes
Mar 30, 2026
Contributor
|
so this can be closed for the other pr? #1887 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the
http.config.ocm.software/v1alpha1config type forcontrolling HTTP client timeouts (dial, TLS handshake, response header,
idle connection, keep-alive, and overall timeout). Timeouts are configured exclusively through the OCM config. When not set,
http.DefaultTransportvalues are preserved unchanged.api/utils/httpclienttransport factory (clones DefaultTransport,selectively overrides from config)
Fixes: #1731