Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This keeps the public
Range<u32>API end-exclusive while converting the range end to the inclusive proof parameter expected by the submit protocol.Why
The wrapper and server passed raw
Range.endvalues into proof parameters even though the proof system treats those maxima as inclusive. That made endpoint values acceptable to the proof logic while the public wrapper rejected them.Impact
Submit request validation and proof verification now agree on the same boundary semantics.
Validation
cargo test -p ooniauth-core test_inclusive_upper_boundcargo test -p ooniauth-core test_submit_request