Bump bzip2 to 0.6 for new rust backend#115
Open
RagnarGrootKoerkamp wants to merge 2 commits intoonecodex:masterfrom
Open
Bump bzip2 to 0.6 for new rust backend#115RagnarGrootKoerkamp wants to merge 2 commits intoonecodex:masterfrom
RagnarGrootKoerkamp wants to merge 2 commits intoonecodex:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into some issues trying to run a binary compiled on my laptop on a server, and it turns out that this is because the server is missing the
libbz2.so.1.0file that is dynamically linked against.The current bzip2
0.4dependency tries to dynamically link againstbz2, and falls back to building from source.One fix would be to simply add the
staticfeature (possibly only enabled via some feature likestatic-bzip2onneedletail), but the simpler fix is probably to just bump it to the current 0.6 as I did here, since it now uses the rust backend by default, which should just fix all these issues completely.Note that some other crates/compression backends also have breaking updates, but it may not be desirable to bump those, because eg linking to
lib-zma0.3.13and0.4.5at the same time is impossible.This is not an issue for
bzip2, because the new version does not link against anything anymore.