[IMP] skip toctree in check_early_line_breaks#17073
Closed
Conversation
Collaborator
Contributor
Felicious
approved these changes
Mar 24, 2026
Contributor
Felicious
left a comment
There was a problem hiding this comment.
Works great with my testing! Thanks @nikibrown (:
robodoo
pushed a commit
that referenced
this pull request
Mar 25, 2026
closes #17073 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
This was referenced Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







Task: https://www.odoo.com/odoo/project/3835/tasks/6065752
Issue:

Make review is showing early line break errors within toctrees:
Solution:
Update check_early_line_breaks function to skip checking for early returns in a toctree.
Testing:
Run
make reviewon a file that has a toctree at the bottom. For example:content/applications/marketing/events.rstExpected output should be
No problems found.