Skip to content

[IMP] skip toctree in check_early_line_breaks#17073

Closed
nikibrown wants to merge 1 commit into17.0from
17.0-make-review-toc-tree-update
Closed

[IMP] skip toctree in check_early_line_breaks#17073
nikibrown wants to merge 1 commit into17.0from
17.0-make-review-toc-tree-update

Conversation

@nikibrown
Copy link
Copy Markdown
Contributor

@nikibrown nikibrown commented Mar 24, 2026

Task: https://www.odoo.com/odoo/project/3835/tasks/6065752

Issue:
Make review is showing early line break errors within toctrees:
image

Solution:
Update check_early_line_breaks function to skip checking for early returns in a toctree.

Testing:
Run make review on a file that has a toctree at the bottom. For example: content/applications/marketing/events.rst

Expected output should be No problems found.

image

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented Mar 24, 2026

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team March 24, 2026 18:33
@Felicious
Copy link
Copy Markdown
Contributor

Tests

Same test as Niki, on the events app page

running make review on applications/marketing/events.rst on the 17.0 branch:
image

running make review on this feature branch:
image

Testing productivity folder (applications/productivity.rst)

On 17.0 (failure case)
image

On feature branch (pass case)
image

Test child folder of an app page (applications/inventory_and_mrp/inventory/product_management.rst)

On 17.0 (failure case)
image

On feature branch (pass case)
image

Copy link
Copy Markdown
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great with my testing! Thanks @nikibrown (:

Copy link
Copy Markdown
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants