Closed
Conversation
Collaborator
|
|
Contributor
Author
|
Hi @huisit this is ready for a review when you have a moment, thanks! |
huisit
reviewed
Mar 20, 2026
huisit
reviewed
Mar 20, 2026
huisit
reviewed
Mar 20, 2026
huisit
reviewed
Mar 20, 2026
huisit
reviewed
Mar 20, 2026
huisit
reviewed
Mar 20, 2026
Contributor
huisit
left a comment
huisit
left a comment
There was a problem hiding this comment.
@stepperpig most of my comments are optional suggestions for conciseness or omitting details that are commonly repeated throughout Odoo apps.
I also shared a few formatting suggestions for structure, but that could definitely be saved for a full rewrite if you're planning to do that later on. Otherwise looks good to me, much better than before!
ps: sorry for the premature comments, I'm still getting used to my new kb and kept hitting ctrl + enter on accident 😅
huisit
approved these changes
Mar 20, 2026
stepperpig
force-pushed
the
18.0-events-update-booths-page-kaili
branch
3 times, most recently
from
533ac18 to
6a49375
Compare
Contributor
Author
|
Hi @Felicious this is ready for a final review! |
Felicious
approved these changes
Mar 25, 2026
Contributor
Felicious
left a comment
Felicious
left a comment
There was a problem hiding this comment.
Gj @stepperpig ! (:
@robodoo delegate+
Contributor
|
updating the scope from 3 to 5 because you touched almost every line and had to update several images (: |
Co-authored-by: Rex <11528309+huisit@users.noreply.github.com> Co-authored-by: Felicia Kuan <freakyotaku@gmail.com>
stepperpig
force-pushed
the
18.0-events-update-booths-page-kaili
branch
from
ec9f1a5 to
0dc8d8a
Compare
Contributor
Author
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 25, 2026
closes #17004 Signed-off-by: Kai Wen Li (kaili) <kaili@odoo.com> Co-authored-by: Rex <11528309+huisit@users.noreply.github.com> Co-authored-by: Felicia Kuan <freakyotaku@gmail.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 26, 2026
closes #17004 Signed-off-by: Kai Wen Li (kaili) <kaili@odoo.com> Co-authored-by: Rex <11528309+huisit@users.noreply.github.com> Co-authored-by: Felicia Kuan <freakyotaku@gmail.com>
This was referenced Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Update the 'Event booths' page to 18.0. This is a significant overhaul to the overall structure and writing of the doc.
Changelog
Additional Notes
This is a pretty large and somewhat "unfocused" doc which may need further work/restructuring in the future to better target specific user needs.
Version Scope
This PR should be FWP up to master. Additional discrepancies in 19.0 will be targeted in a future PR.