fix: use keyed_window.keys for task lookup in accumulator task manager#330
Draft
fix: use keyed_window.keys for task lookup in accumulator task manager#330
Conversation
payload.keys is empty on CLOSE operations since no data is attached, causing "accumulator task not found" errors. keyed_window.keys is the authoritative key identity populated for all operation types. Also updates tests to set keyedWindow.keys independently from payload.keys to match real platform behavior. Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #330 +/- ##
==========================================
+ Coverage 94.17% 94.20% +0.03%
==========================================
Files 66 66
Lines 3092 3091 -1
Branches 162 162
==========================================
Hits 2912 2912
Misses 149 149
+ Partials 31 30 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #327
payload.keysis empty onCLOSEoperations since no data is attached, causing "accumulator task not found" errors. keyed_window.keys is the authoritative key identity populated for all operation types. Also updates tests to set keyedWindow.keys independently from payload.keys to match real platform behavior.I was able to reproduce the issue consistently with the pipeline mentioned in bug report. I'm running the same pipeline locally for an hour now with this fix, no issues so far and messages are reaching sink.