Skip to content

fix: fix the logic for the UNDICI_NO_WASM_SIMD environment variable#5026

Merged
mcollina merged 1 commit intonodejs:mainfrom
ShenHongFei:fix-undici-no-wasm-simd
Apr 14, 2026
Merged

fix: fix the logic for the UNDICI_NO_WASM_SIMD environment variable#5026
mcollina merged 1 commit intonodejs:mainfrom
ShenHongFei:fix-undici-no-wasm-simd

Conversation

@ShenHongFei
Copy link
Copy Markdown
Contributor

Rationale

The original function of the UNDICI_NO_WASM_SIMD environment variable was reversed. It has been fixed now.

Changes

Fixed the erroneous logic of UNDICI_NO_WASM_SIMD

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

N/A

Status

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.03%. Comparing base (6824eed) to head (11f65ab).

Files with missing lines Patch % Lines
lib/dispatcher/client-h1.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5026      +/-   ##
==========================================
- Coverage   93.04%   93.03%   -0.02%     
==========================================
  Files         110      110              
  Lines       35793    35793              
==========================================
- Hits        33305    33301       -4     
- Misses       2488     2492       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina
Copy link
Copy Markdown
Member

cc @Uzlopak @richardlau this seems correct. Wdyt?

@richardlau
Copy link
Copy Markdown
Member

FWIW we can probably rework the assumption to disable by default on Power now as the V8 fix has been backported to all in support LTS Node.js release lines, but I guess we'd need an allow list of Node.js versions as Undici might be being run on an older, e.g. Node.js 24 release before the fix went in.

@mcollina mcollina merged commit 0860142 into nodejs:main Apr 14, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants