fix: fix the logic for the UNDICI_NO_WASM_SIMD environment variable#5026
Merged
mcollina merged 1 commit intonodejs:mainfrom Apr 14, 2026
Merged
fix: fix the logic for the UNDICI_NO_WASM_SIMD environment variable#5026mcollina merged 1 commit intonodejs:mainfrom
mcollina merged 1 commit intonodejs:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5026 +/- ##
==========================================
- Coverage 93.04% 93.03% -0.02%
==========================================
Files 110 110
Lines 35793 35793
==========================================
- Hits 33305 33301 -4
- Misses 2488 2492 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
cc @Uzlopak @richardlau this seems correct. Wdyt? |
richardlau
approved these changes
Apr 13, 2026
Member
|
FWIW we can probably rework the assumption to disable by default on Power now as the V8 fix has been backported to all in support LTS Node.js release lines, but I guess we'd need an allow list of Node.js versions as Undici might be being run on an older, e.g. Node.js 24 release before the fix went in. |
metcoder95
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The original function of the UNDICI_NO_WASM_SIMD environment variable was reversed. It has been fixed now.
Changes
Fixed the erroneous logic of UNDICI_NO_WASM_SIMD
Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status