Skip to content

fix(proxy agent): respect connectTimeout#5011

Merged
mcollina merged 2 commits intonodejs:mainfrom
rozzilla:fix/proxy-agent/respect-connectTimeout
Apr 12, 2026
Merged

fix(proxy agent): respect connectTimeout#5011
mcollina merged 2 commits intonodejs:mainfrom
rozzilla:fix/proxy-agent/respect-connectTimeout

Conversation

@rozzilla
Copy link
Copy Markdown
Contributor

@rozzilla rozzilla commented Apr 9, 2026

This relates to...

Fixes #4983.

Rationale

ProxyAgent inherits connectTimeout, but it was not forwarding that value to its internal connectors. This meant proxy connections could still use the default 10-second timeout instead of the configured one.

Changes

  • forward connectTimeout to the proxy connector
  • forward connectTimeout to the request connectors
  • add a regression test for the timeout behavior

Features

n/a

Bug Fixes

n/a

Breaking Changes and Deprecations

n/a

Status

Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.92%. Comparing base (0143e1b) to head (b04759c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5011      +/-   ##
==========================================
- Coverage   92.93%   92.92%   -0.01%     
==========================================
  Files         110      110              
  Lines       35739    35739              
==========================================
- Hits        33214    33212       -2     
- Misses       2525     2527       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@mcollina mcollina merged commit 7ca6bb3 into nodejs:main Apr 12, 2026
35 checks passed
@github-actions github-actions bot mentioned this pull request Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proxies don't accept my timeout and always have a static 10_000 ms.

4 participants