docs: clarify file extension for module type#8697
Open
danielrhodeswarp wants to merge 1 commit intonodejs:mainfrom
Open
docs: clarify file extension for module type#8697danielrhodeswarp wants to merge 1 commit intonodejs:mainfrom
danielrhodeswarp wants to merge 1 commit intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
avivkeller
approved these changes
Mar 5, 2026
aymen94
approved these changes
Mar 5, 2026
Member
|
LGTM |
AugustinMauroy
approved these changes
Mar 5, 2026
ovflowd
approved these changes
Mar 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8697 +/- ##
==========================================
+ Coverage 75.05% 75.10% +0.04%
==========================================
Files 104 104
Lines 9161 9161
Branches 316 315 -1
==========================================
+ Hits 6876 6880 +4
+ Misses 2283 2279 -4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have clarified this point which was, at least for me, a bit of a "huh?" moment:
"If you use mjs version of the code,..." when the code snippets prior are simply labelled CJS and ESM.
So I suggest a change to:
"If you use the ESM version of the code,..."
Validation
Check, in the browser, the first page of "Introduction to Node.js". The change is just after the first code snippet.
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.