Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website @nodejs/web-infra Please review the changes when you have a chance. Thank you! 🙏 |
|
Vercel is not enjoying this git-hosted dependency, it seems. So, this is blocked by nodejs/doc-kit#624. |
There was a problem hiding this comment.
Pull request overview
This PR bumps the @nodejs/doc-kit dependency used by the @node-core/remark-lint package to a newer git commit so future remark-lint rules can rely on updated doc-kit logic (e.g., more accurate regexes).
Changes:
- Update
@nodejs/doc-kitgit SHA inpackages/remark-lint/package.json. - Regenerate
pnpm-lock.yamlto reflect the new doc-kit commit and its updated dependency graph.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/remark-lint/package.json |
Updates the doc-kit git reference used by the remark-lint package. |
pnpm-lock.yaml |
Updates the lockfile to match the new doc-kit commit and its transitive dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📦 Build Size ComparisonSummary
Changes➕ Added Assets (1)
➖ Removed Assets (1)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8694 +/- ##
==========================================
+ Coverage 75.06% 75.11% +0.04%
==========================================
Files 104 104
Lines 9161 9161
Branches 316 315 -1
==========================================
+ Hits 6877 6881 +4
+ Misses 2282 2278 -4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
cc @nodejs/web-infra for reviewed |
This bump will enable Dependabot to bump doc-kit in the future.
Why is the diff so big?
The version of
doc-kitpreviously used was extremely out-of-date, and had a number of dependencies no longer needed (i.e. the old, extremely large Orama bundle)