Skip to content

feat: add system theme toggle#8659

Merged
avivkeller merged 1 commit intonodejs:mainfrom
araujogui:feat/system-theme
Feb 27, 2026
Merged

feat: add system theme toggle#8659
avivkeller merged 1 commit intonodejs:mainfrom
araujogui:feat/system-theme

Conversation

@araujogui
Copy link
Member

@araujogui araujogui commented Feb 25, 2026

Description

Add system theme toggle

Validation

image

Related Issues

Related to nodejs/doc-kit#597

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@araujogui araujogui requested a review from a team as a code owner February 25, 2026 20:27
@vercel
Copy link

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Feb 25, 2026 8:29pm

Request Review

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

❌ Patch coverage is 67.64706% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.08%. Comparing base (3dd2deb) to head (ed1e50e).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ges/ui-components/src/Common/ThemeToggle/index.tsx 67.64% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8659      +/-   ##
==========================================
- Coverage   75.12%   75.08%   -0.05%     
==========================================
  Files         104      104              
  Lines        9098     9159      +61     
  Branches      314      315       +1     
==========================================
+ Hits         6835     6877      +42     
- Misses       2261     2280      +19     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeesto
Copy link
Member

I think you might have linked to the wrong issue?

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice job

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2026

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 93 🟢 100 🟢 100 🔗
/en/about 🟢 99 🟢 94 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 98 🟢 97 🟢 100 🟢 100 🔗
/en/download 🟢 99 🟢 96 🟠 81 🟢 100 🔗
/en/download/archive/current 🟢 100 🟢 97 🟢 100 🟢 100 🔗
/en/blog 🟢 98 🟢 97 🟢 96 🟢 100 🔗

Copy link
Member

@canerakdas canerakdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avivkeller avivkeller added this pull request to the merge queue Feb 27, 2026
Merged via the queue into nodejs:main with commit 7a8d5bd Feb 27, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants