Skip to content

crypto: strengthen argument CHECKs in TurboSHAKE#62763

Open
tniessen wants to merge 1 commit intonodejs:mainfrom
tniessen:crypto-turboshake-strenghten-arg-check
Open

crypto: strengthen argument CHECKs in TurboSHAKE#62763
tniessen wants to merge 1 commit intonodejs:mainfrom
tniessen:crypto-turboshake-strenghten-arg-check

Conversation

@tniessen
Copy link
Copy Markdown
Member

Instead of first discarding the top 24 bits of the argument and then checking that the low 8 bits are within the expected range, first check that the original 32-bit integer is within the expected range and then discard the top 24 bits.

Instead of first discarding the top 24 bits of the argument and then
checking that the low 8 bits are within the expected range, first check
that the original 32-bit integer is within the expected range and then
discard the top 24 bits.
@tniessen tniessen requested a review from panva April 15, 2026 21:42
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 15, 2026
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 15, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 15, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.68%. Comparing base (3f52482) to head (23b2a6a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/crypto/crypto_turboshake.cc 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62763      +/-   ##
==========================================
- Coverage   91.55%   89.68%   -1.87%     
==========================================
  Files         356      706     +350     
  Lines      149601   218127   +68526     
  Branches    23395    41734   +18339     
==========================================
+ Hits       136967   195632   +58665     
- Misses      12371    14406    +2035     
- Partials      263     8089    +7826     
Files with missing lines Coverage Δ
src/crypto/crypto_turboshake.cc 82.81% <50.00%> (ø)

... and 471 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 16, 2026
@panva
Copy link
Copy Markdown
Member

panva commented Apr 16, 2026

Thanks @tniessen, good spot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue Add this label to land a pull request using GitHub Actions. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants