node-api: add napi_create_external_sharedarraybuffer by bnoordhuis · Pull Request #62623 · nodejs/node

bnoordhuis · 2026-04-07T09:16:02Z

Creates a SharedArrayBuffer from externally managed memory.

Fixes: #62259

Creates a SharedArrayBuffer from externally managed memory. Fixes: nodejs#62259

nodejs-github-bot · 2026-04-07T09:16:07Z

Review requested:

@nodejs/node-api

codecov · 2026-04-07T11:38:36Z

Codecov Report

❌ Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.80%. Comparing base (f48ac91) to head (bfed127).
⚠️ Report is 91 commits behind head on main.

Files with missing lines	Patch %	Lines
src/js_native_api_v8.cc	72.00%	0 Missing and 7 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62623      +/-   ##
==========================================
+ Coverage   89.77%   89.80%   +0.03%     
==========================================
  Files         697      699       +2     
  Lines      215749   216404     +655     
  Branches    41304    41379      +75     
==========================================
+ Hits       193681   194344     +663     
+ Misses      14161    14139      -22     
- Partials     7907     7921      +14

Files with missing lines	Coverage Δ
src/js_native_api_v8.cc	`76.43% <72.00%> (-0.06%)`	⬇️

... and 67 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina

lgtm

nodejs-github-bot · 2026-04-07T12:16:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72534/

nodejs-github-bot · 2026-04-10T15:25:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72608/

nodejs-github-bot · 2026-04-13T15:05:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72672/

bnoordhuis · 2026-04-15T19:15:32Z

Test failures look like unrelated flakes. Concur/disagree?

nodejs-github-bot · 2026-04-17T00:48:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72728/

nodejs-github-bot · 2026-04-17T05:46:10Z

Commit Queue failed

- Loading data for nodejs/node/pull/62623
✔  Done loading data for nodejs/node/pull/62623
----------------------------------- PR info ------------------------------------
Title      node-api: add napi_create_external_sharedarraybuffer (#62623)
Author     Ben Noordhuis <info@bnoordhuis.nl> (@bnoordhuis)
Branch     bnoordhuis:fix62259 -> nodejs:main
Labels     c++, node-api, needs-ci
Commits    13
 - node-api: add napi_create_external_sharedarraybuffer
 - squash! lint
 - squash! more lint
 - squash! more lint
 - squash! more more lint
 - squash! review feedback
 - squash! preamble
 - squash! lint
 - squash! update binding.gyp
 - squash! review feedback
 - squash! introduce node_api_noenv_finalize
 - squash! lint
 - squash! lint
Committers 1
 - Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: https://github.com/nodejs/node/pull/62623
Fixes: https://github.com/nodejs/node/issues/62259
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62623
Fixes: https://github.com/nodejs/node/issues/62259
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 07 Apr 2026 09:16:02 GMT
   ✔  Approvals: 4
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/62623#pullrequestreview-4067842600
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/62623#pullrequestreview-4085641875
   ✔  - Vladimir Morozov (@vmoroz): https://github.com/nodejs/node/pull/62623#pullrequestreview-4090466256
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/62623#pullrequestreview-4099636726
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-04-17T00:48:36Z: https://ci.nodejs.org/job/node-test-pull-request/72728/
- Querying data for job/node-test-pull-request/72728/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 62623
From https://github.com/nodejs/node
 * branch                  refs/pull/62623/merge -> FETCH_HEAD
✔  Fetched commits as b17884248282..bfed127d0ae3
--------------------------------------------------------------------------------
[main f1207fe5eb] node-api: add napi_create_external_sharedarraybuffer
 Author: Ben Noordhuis <info@bnoordhuis.nl>
 Date: Tue Apr 7 11:11:15 2026 +0200
 5 files changed, 130 insertions(+)
[main 7159a586ee] squash! lint
 Author: Ben Noordhuis <info@bnoordhuis.nl>
 Date: Tue Apr 7 11:21:05 2026 +0200
 3 files changed, 29 insertions(+), 32 deletions(-)
[main 3964c082cc] squash! more lint
 Author: Ben Noordhuis <info@bnoordhuis.nl>
 Date: Tue Apr 7 11:40:41 2026 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 676f03badb] squash! more lint
 Author: Ben Noordhuis <info@bnoordhuis.nl>
 Date: Tue Apr 7 11:49:16 2026 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 8473e978f8] squash! more more lint
 Author: Ben Noordhuis <info@bnoordhuis.nl>
 Date: Tue Apr 7 12:13:31 2026 +0200
 1 file changed, 2 insertions(+), 2 deletions(-)
[main d4e74061d6] squash! review feedback
 Author: Ben Noordhuis <info@bnoordhuis.nl>
 Date: Thu Apr 9 22:48:09 2026 +0200
 4 files changed, 55 insertions(+), 58 deletions(-)
[main bc31f30dcc] squash! preamble
 Author: Ben Noordhuis <info@bnoordhuis.nl>
 Date: Thu Apr 9 22:53:52 2026 +0200
 1 file changed, 2 insertions(+)
[main eda9894d34] squash! lint
 Author: Ben Noordhuis <info@bnoordhuis.nl>
 Date: Thu Apr 9 23:16:58 2026 +0200
 1 file changed, 2 insertions(+), 3 deletions(-)
[main 41af729d99] squash! update binding.gyp
 Author: Ben Noordhuis <info@bnoordhuis.nl>
 Date: Thu Apr 9 23:19:58 2026 +0200
 1 file changed, 3 insertions(+), 1 deletion(-)
[main c38c77a77b] squash! review feedback
 Author: Ben Noordhuis <info@bnoordhuis.nl>
 Date: Sun Apr 12 17:04:07 2026 +0200
 2 files changed, 3 insertions(+), 2 deletions(-)
[main 46c8ce4f4d] squash! introduce node_api_noenv_finalize
 Author: Ben Noordhuis <info@bnoordhuis.nl>
 Date: Sun Apr 12 17:11:36 2026 +0200
 4 files changed, 7 insertions(+), 5 deletions(-)
[main ca7335e260] squash! lint
 Author: Ben Noordhuis <info@bnoordhuis.nl>
 Date: Sun Apr 12 17:17:46 2026 +0200
 2 files changed, 14 insertions(+), 14 deletions(-)
[main 000b2014b1] squash! lint
 Author: Ben Noordhuis <info@bnoordhuis.nl>
 Date: Sun Apr 12 17:55:29 2026 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
Please run the following commands to complete landing
$ git rebase origin/main --no-keep-empty -i -x "git node land --amend" --autosquash

$ git node land --continue

https://github.com/nodejs/node/actions/runs/24549787442

nodejs-github-bot · 2026-04-17T15:10:38Z

Landed in c1d7150

node-api: add napi_create_external_sharedarraybuffer

3b8f808

Creates a SharedArrayBuffer from externally managed memory. Fixes: nodejs#62259

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. labels Apr 7, 2026

github-project-automation bot added this to Node-API Team Project Apr 7, 2026

github-project-automation bot moved this to Need Triage in Node-API Team Project Apr 7, 2026

bnoordhuis added 2 commits April 7, 2026 11:21

squash! lint

6bc42e2

squash! more lint

32fe154

bnoordhuis force-pushed the fix62259 branch from d461da4 to 32fe154 Compare April 7, 2026 09:40

bnoordhuis added 2 commits April 7, 2026 11:49

squash! more lint

5578c1a

squash! more more lint

5d2dd37

ronag requested review from addaleax, jasnell and joyeecheung April 7, 2026 11:18

mcollina approved these changes Apr 7, 2026

View reviewed changes

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2026

ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 7, 2026

ronag requested a review from vmoroz April 7, 2026 14:16

legendecas reviewed Apr 7, 2026

View reviewed changes

Comment thread src/js_native_api.h Outdated

Comment thread test/node-api/test_buffer/test.js

Comment thread doc/api/n-api.md Outdated

Comment thread doc/api/n-api.md

legendecas removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 7, 2026

legendecas moved this from Need Triage to In Progress in Node-API Team Project Apr 7, 2026

KevinEady reviewed Apr 7, 2026

View reviewed changes

Comment thread src/js_native_api.h Outdated

KevinEady reviewed Apr 7, 2026

View reviewed changes

Comment thread src/js_native_api_v8.cc Outdated

vmoroz reviewed Apr 7, 2026

View reviewed changes

Comment thread doc/api/n-api.md Outdated

vmoroz reviewed Apr 7, 2026

View reviewed changes

Comment thread src/js_native_api.h Outdated

vmoroz reviewed Apr 7, 2026

View reviewed changes

Comment thread src/js_native_api_v8.cc Outdated

squash! update binding.gyp

a021c17

legendecas approved these changes Apr 9, 2026

View reviewed changes

Comment thread test/node-api/test_buffer/test.js

vmoroz reviewed Apr 10, 2026

View reviewed changes

Comment thread test/node-api/test_buffer/binding.gyp Outdated

vmoroz approved these changes Apr 10, 2026

View reviewed changes

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 10, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 10, 2026

bnoordhuis added 4 commits April 12, 2026 17:04

squash! review feedback

f1c9e37

squash! introduce node_api_noenv_finalize

f47eed4

squash! lint

b29bb10

squash! lint

bfed127

ronag approved these changes Apr 13, 2026

View reviewed changes

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2026

ronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 17, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 17, 2026

legendecas approved these changes Apr 17, 2026

View reviewed changes

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 17, 2026

nodejs-github-bot merged commit c1d7150 into nodejs:main Apr 17, 2026
83 checks passed

github-project-automation bot moved this from In Progress to Done in Node-API Team Project Apr 17, 2026

Uh oh!

Conversation

bnoordhuis commented Apr 7, 2026

Uh oh!

nodejs-github-bot commented Apr 7, 2026

Uh oh!

codecov bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Apr 7, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 10, 2026

Uh oh!

nodejs-github-bot commented Apr 13, 2026

Uh oh!

bnoordhuis commented Apr 15, 2026

Uh oh!

nodejs-github-bot commented Apr 17, 2026

Uh oh!

nodejs-github-bot commented Apr 17, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov bot commented Apr 7, 2026 •

edited

Loading