test_runner: publish to TracingChannel node.test for OTel instrumentation by MoLow · Pull Request #62502 · nodejs/node

MoLow · 2026-03-30T10:54:04Z

No description provided.

nodejs-github-bot · 2026-03-30T10:54:11Z

Review requested:

@nodejs/test_runner

benjamingr

really cool

Copilot

Pull request overview

Adds diagnostics channel tracing hooks to the built-in Node.js test runner to enable OpenTelemetry-style instrumentation via diagnostics_channel.tracingChannel('node.test').

Changes:

Introduce a shared TracingChannel('node.test') for the internal test runner and export it from test-runner utils.
Wrap test/suite execution with start.runStores(...) and publish end/error lifecycle events.
Add documentation and new tests/fixtures validating lifecycle events and AsyncLocalStorage propagation via bindStore().

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
test/parallel/test-runner-diagnostics-channel.js	New parallel test covering start/end/error events and `bindStore` propagation.
test/fixtures/test-runner/diagnostics-channel-error-test.js	Fixture that intentionally fails to validate `error` event emission.
lib/internal/test_runner/utils.js	Creates and exports `testChannel` via `diagnostics_channel.tracingChannel('node.test')`.
lib/internal/test_runner/test.js	Instruments `Test.run()` and `Suite.createBuild()` to emit tracing lifecycle events and run stores.
doc/api/test.md	Documents the new tracing channels and provides an OpenTelemetry integration example.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2026-03-30T12:32:05Z

Codecov Report

❌ Patch coverage is 95.58824% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.80%. Comparing base (4563cb3) to head (c055153).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/test_runner/test.js	95.38%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62502      +/-   ##
==========================================
+ Coverage   88.93%   89.80%   +0.87%     
==========================================
  Files         699      699              
  Lines      216379   216445      +66     
  Branches    41281    41384     +103     
==========================================
+ Hits       192434   194380    +1946     
+ Misses      15976    14152    -1824     
+ Partials     7969     7913      -56

Files with missing lines	Coverage Δ
lib/internal/test_runner/utils.js	`63.58% <100.00%> (+0.14%)`	⬆️
lib/internal/test_runner/test.js	`96.88% <95.38%> (-0.06%)`	⬇️

... and 108 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-04-13T07:44:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72663/

nodejs-github-bot · 2026-04-13T09:01:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72664/

nodejs-github-bot · 2026-04-13T09:55:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72666/

nodejs-github-bot · 2026-04-13T10:18:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72667/

nodejs-github-bot · 2026-04-13T11:43:02Z

Commit Queue failed

- Loading data for nodejs/node/pull/62502
✔  Done loading data for nodejs/node/pull/62502
----------------------------------- PR info ------------------------------------
Title      test_runner: publish to TracingChannel node.test for OTel instrumentation (#62502)
Author     Moshe Atlow <moshe@atlow.co.il> (@MoLow)
Branch     MoLow:test-tracing-channel -> nodejs:main
Labels     author ready, needs-ci, test_runner
Commits    1
 - test_runner: publish to TracingChannel node.test for instrumentation
Committers 1
 - Moshe Atlow <moshe@atlow.co.il>
PR-URL: https://github.com/nodejs/node/pull/62502
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62502
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 30 Mar 2026 10:54:04 GMT
   ✔  Approvals: 2
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/62502#pullrequestreview-4029731280
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/62502#pullrequestreview-4096943911
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-04-13T10:18:09Z: https://ci.nodejs.org/job/node-test-pull-request/72667/
- Querying data for job/node-test-pull-request/72667/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 62502
From https://github.com/nodejs/node
 * branch                  refs/pull/62502/merge -> FETCH_HEAD
✔  Fetched commits as 0546822c31ae..c05515399d7c
--------------------------------------------------------------------------------
[main dd8b286573] test_runner: publish to TracingChannel node.test for instrumentation
 Author: Moshe Atlow <moshe@atlow.co.il>
 Date: Mon Mar 30 11:37:41 2026 +0300
 5 files changed, 309 insertions(+), 2 deletions(-)
 create mode 100644 test/fixtures/test-runner/diagnostics-channel-error-test.js
 create mode 100644 test/parallel/test-runner-diagnostics-channel.js
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
PR-URL: https://github.com/nodejs/node/pull/62502
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
--------------------------------------------------------------------------------
[main f9214280b4] PR-URL: https://github.com/nodejs/node/pull/62502 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 Author: Moshe Atlow <moshe@atlow.co.il>
 Date: Mon Mar 30 11:37:41 2026 +0300
 5 files changed, 309 insertions(+), 2 deletions(-)
 create mode 100644 test/fixtures/test-runner/diagnostics-channel-error-test.js
 create mode 100644 test/parallel/test-runner-diagnostics-channel.js
  ✖  f9214280b4f4f3e9c87f8fb6a35d9ff1c504ce86
     ✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer
     ✔  0:0      skipping fixes-url                        fixes-url
     ✖  1:0      blank line expected after title           line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      metadata is at end of message             metadata-end
     ✖  0:0      Commit must have a PR-URL.                pr-url
     ✔  0:0      reviewers are valid                       reviewers
     ✖  0:0      Invalid subsystem: "PR-URL"               subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ✔  0:0      Title is <= 50 columns.                   title-length
   ℹ  Please fix the commit message and try again.
Please manually ammend the commit message, by running
`git commit --amend`
Once commit message is fixed, finish the landing command running
`git node land --continue`

https://github.com/nodejs/node/actions/runs/24341353410

Signed-off-by: Moshe Atlow <moshe@atlow.co.il> PR-URL: #62502 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

MoLow · 2026-04-13T12:02:13Z

Landed in c7d05fc

MoLow requested a review from Copilot March 30, 2026 10:54

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Mar 30, 2026

Copilot started reviewing on behalf of MoLow March 30, 2026 10:55 View session

benjamingr approved these changes Mar 30, 2026

View reviewed changes

Copilot AI reviewed Mar 30, 2026

View reviewed changes

Comment thread doc/api/test.md

Comment thread doc/api/test.md Outdated

Comment thread lib/internal/test_runner/test.js Outdated

Comment thread lib/internal/test_runner/test.js

atlowChemi reviewed Mar 30, 2026

View reviewed changes

Comment thread doc/api/test.md Outdated

atlowChemi reviewed Mar 30, 2026

View reviewed changes

Comment thread doc/api/test.md Outdated

MoLow force-pushed the test-tracing-channel branch from c3b10e5 to 75fe3a3 Compare March 30, 2026 11:08

atlowChemi reviewed Mar 30, 2026

View reviewed changes

Comment thread test/parallel/test-runner-diagnostics-channel.js Outdated

atlowChemi reviewed Mar 30, 2026

View reviewed changes

Comment thread test/parallel/test-runner-diagnostics-channel.js Outdated

test_runner: publish to TracingChannel node.test for instrumentation

c055153

MoLow force-pushed the test-tracing-channel branch from 75fe3a3 to c055153 Compare April 13, 2026 06:57

MoLow requested a review from atlowChemi April 13, 2026 06:58

atlowChemi approved these changes Apr 13, 2026

View reviewed changes

atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2026

MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 13, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 13, 2026

MoLow closed this Apr 13, 2026

MoLow removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 13, 2026

Uh oh!

Conversation

MoLow commented Mar 30, 2026

Uh oh!

nodejs-github-bot commented Mar 30, 2026

Uh oh!

benjamingr left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Apr 13, 2026

Uh oh!

nodejs-github-bot commented Apr 13, 2026

Uh oh!

nodejs-github-bot commented Apr 13, 2026

Uh oh!

nodejs-github-bot commented Apr 13, 2026

Uh oh!

nodejs-github-bot commented Apr 13, 2026

Uh oh!

MoLow commented Apr 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Mar 30, 2026 •

edited

Loading