Skip to content

Update Dependencies #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cjbarth wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Update Dependencies #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b845521
Some minor dependency updates
cjbarth Mar 4, 2026
29880ee
Update typescript
cjbarth Mar 4, 2026
749c92b
Update xmldom
cjbarth Mar 4, 2026
8569690
New major version of xmldom
cjbarth Mar 4, 2026
eac5f9b
add agents.md
cjbarth Mar 4, 2026
c9c4bb9
eslint@9
cjbarth Mar 4, 2026
79eb8ac
eslint@10
cjbarth Mar 4, 2026
3162fb8
mocha + nyc
cjbarth Mar 5, 2026
7550c90
update some more
cjbarth Mar 5, 2026
3cf4de6
Add import linting
cjbarth Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file removed .eslintignore
View file
Open in desktop
Empty file.
37 changes: 0 additions & 37 deletions .eslintrc.json
View file
Open in desktop

This file was deleted.

19 changes: 19 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Agent Notes

## Scope

- This repository is a Node.js/TypeScript library.
- Only work in `src/` and `test/` unless explicitly asked to do otherwise.
- Treat all changes as security-sensitive; this library is foundational for other security-focused projects (e.g., `node-saml`).

## Conventions

- Keep changes minimal and focused.
- Prefer defensive coding and preserve existing security properties.
- Follow existing project style and lint rules.
- Don't edit `node_modules/`.

## Verification

- After all changes, run:
- `npm run build && npm test && npm run lint:fix`
62 changes: 62 additions & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
const js = require("@eslint/js");
const tseslint = require("typescript-eslint");
const globals = require("globals");
const prettierConfig = require("eslint-config-prettier");
const simpleImportSort = require("eslint-plugin-simple-import-sort");

module.exports = tseslint.config(
js.configs.recommended,
...tseslint.configs.recommended,
{
files: ["**/*.ts"],
plugins: {
"simple-import-sort": simpleImportSort,
},
languageOptions: {
parserOptions: {
project: "./tsconfig.eslint.json",
tsconfigRootDir: __dirname,
sourceType: "module",
},
globals: {
...globals.node,
...globals.mocha,
...globals.es2020,
Attr: "readonly",
ChildNode: "readonly",
Comment: "readonly",
Document: "readonly",
Element: "readonly",
Node: "readonly",
XPathNSResolver: "readonly",
},
},
rules: {
"simple-import-sort/imports": "error",
"simple-import-sort/exports": "error",
"no-console": "error",
"no-prototype-builtins": "error",
"one-var": ["error", "never"],
"no-duplicate-imports": "error",
"no-use-before-define": "error",
Copy link

@coderabbitai coderabbitai bot Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

find . -name "eslint.config.js" -type f

Repository: node-saml/xml-crypto

Length of output: 82

🏁 Script executed:

cat -n eslint.config.js

Repository: node-saml/xml-crypto

Length of output: 2235

🏁 Script executed:

head -50 eslint.config.js | cat -n

Repository: node-saml/xml-crypto

Length of output: 1979

🏁 Script executed:

wc -l eslint.config.js && head -62 eslint.config.js | cat -n

Repository: node-saml/xml-crypto

Length of output: 2255

🌐 Web query:

no-use-before-define vs @typescript-eslint/no-use-before-define TypeScript

💡 Result:

What’s the difference?

no-use-before-define (ESLint core)

  • The built-in ESLint rule that flags using identifiers before they’re declared (variables, functions, classes, etc.). (eslint.org)

@typescript-eslint/no-use-before-define (TypeScript-ESLint)

  • A TypeScript-aware version that extends the ESLint core rule to better handle TypeScript syntax/semantics. (typescript-eslint.io)

Which should you use in TypeScript?

  • In TypeScript projects, the common guidance is: turn off the ESLint core rule and turn on @typescript-eslint/no-use-before-define, to avoid incorrect reports and ensure TS syntax is handled properly. (typescript-eslint.io)

Typical config

// .eslintrc.cjs / .eslintrc.js
module.exports = {
  rules: {
    "no-use-before-define": "off",
    "@typescript-eslint/no-use-before-define": "error",
  },
};

(typescript-eslint.io)

Citations:

Use the TypeScript-aware no-use-before-define rule.

The core ESLint rule cannot properly handle TypeScript syntax and semantics, causing incorrect or noisy lint failures. Replace it with @typescript-eslint/no-use-before-define.

Proposed fix 
-      "no-use-before-define": "error",
+      "no-use-before-define": "off",
+      "@typescript-eslint/no-use-before-define": "error",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"no-use-before-define": "error",
"no-use-before-define": "off",
"@typescript-eslint/no-use-before-define": "error",
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@eslint.config.js` at line 41, Replace the core ESLint rule
"no-use-before-define" with the TypeScript-aware
"@typescript-eslint/no-use-before-define" in the config: remove or disable
"no-use-before-define" and add "@typescript-eslint/no-use-before-define":
"error" (or desired setting) so TypeScript syntax is handled correctly; update
any rule ordering or plugin entries if needed to ensure "@typescript-eslint"
rules are applied.

curly: "error",
eqeqeq: ["error", "smart"],
"no-var": "error",
"prefer-const": "error",
"prefer-template": "error",
"@typescript-eslint/no-deprecated": "error",
"@typescript-eslint/no-non-null-assertion": "error",
"@typescript-eslint/no-unused-vars": "error",
"@typescript-eslint/no-this-alias": "error",
},
},
{
files: ["test/**/*.ts"],
rules: {
"@typescript-eslint/no-unused-expressions": "off",
},
},
{
rules: prettierConfig.rules,
},
);
Loading