fix: prevent file handle leak when maxFiles is exceeded#1068
Open
guoyangzhen wants to merge 1 commit intonode-formidable:masterfrom
Open
fix: prevent file handle leak when maxFiles is exceeded#1068guoyangzhen wants to merge 1 commit intonode-formidable:masterfrom
guoyangzhen wants to merge 1 commit intonode-formidable:masterfrom
Conversation
Fixes node-formidable#987 When maxFiles limit is reached, the fileBegin event handler calls _error(), but _handlePart continues and opens a write stream for the new file. These file handles are never closed. Fix: check this.error after emitting fileBegin and before file.open(). If an error occurred (e.g., maxFiles exceeded), decrement _flushing and return early to prevent the file stream from being opened.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #987
Problem
When
options.maxFilesis set and a request exceeds the limit, file handles are leaked and never released until the process exits.Root cause in
_handlePart:this.emit('fileBegin', part.name, file)— triggers the maxFiles checkthis._error(), destroying files inthis.openedFiles_handlePartcontinues and callsfile.open()+this.openedFiles.push(file)Fix
Check
this.errorafter emittingfileBeginbut beforefile.open(). If an error occurred (e.g., maxFiles exceeded), decrement_flushingand return early to prevent opening the file stream.Reproduction
With the fix, no file handles are leaked when maxFiles is exceeded.