fix: update Node.js version requirement to >= 18#1067
Open
mahmoodhamdi wants to merge 1 commit intonode-formidable:masterfrom
Open
fix: update Node.js version requirement to >= 18#1067mahmoodhamdi wants to merge 1 commit intonode-formidable:masterfrom
mahmoodhamdi wants to merge 1 commit intonode-formidable:masterfrom
Conversation
The codebase uses `node:` prefixed imports (e.g. `node:fs`, `node:crypto`, `node:events`) which require Node.js >= 14.18.0, and CI only tests Node.js 18, 20, 22, and LTS. Updated the minimum version to >= 18 to match: - package.json engines: 14.0.0 -> 18.0.0 - README.md text: >= 20 -> >= 18 - README.md badge: >= 10.13 -> >= 18 - README_pt_BR.md text and badge: >= 10.13 -> >= 18 Fixes node-formidable#976 Co-Authored-By: Mahmoud Hamdi <hmdy7486@gmail.com>
Contributor
|
Thanks mahmoodhamdi , could you please review #1066 before ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Node.js version requirement was inconsistent across the project:
package.jsonengines>=14.0.0>=18.0.0>= 20>= 18>= 10.13>= 18>= 10.13>= 18>= 10.13>= 18The CI matrix tests Node.js 18, 20, 22, and LTS, so
>= 18is the correct minimum supported version.Fixes #976