chore(cleanup): replace markdownit-katex with @mdit/tex#8342
Open
max-nextcloud wants to merge 1 commit intomainfrom
Open
chore(cleanup): replace markdownit-katex with @mdit/tex#8342max-nextcloud wants to merge 1 commit intomainfrom
max-nextcloud wants to merge 1 commit intomainfrom
Conversation
max-nextcloud
force-pushed
the
fix/duplicate-katex-import
branch
3 times, most recently
from
e78f63a to
4f8bade
Compare
The latex does not need to be rendered during the markdown processing. It was extracted from the annotation afterwards anyways. This avoids a duplicate import of KaTex which shrinks our largest chunk from 2.4 Mb to 2.1 Mb. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
fix/duplicate-katex-import
branch
from
4f8bade to
966e011
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latex does not need to be rendered during the markdown processing.
It was extracted from the annotation afterwards anyways.
This avoids a duplicate import of KaTex which shrinks our largest chunk
from 2.4 Mb to 2.1 Mb.