[RFC] merge viewer app into server repository#60480
Draft
susnux wants to merge 3769 commits into
Draft
Conversation
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Bumps [tmp](https://github.com/raszi/node-tmp) from 0.2.3 to 0.2.4. - [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md) - [Commits](raszi/node-tmp@v0.2.3...v0.2.4) --- updated-dependencies: - dependency-name: tmp dependency-version: 0.2.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
chore(deps): update dependency typescript to ^5.9.2 (master)
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
…-update build: update node and npm engines versions
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
The ownerId is supposed to always be a string value, but if someone's userId is a Numeric name, then file deletion breaks, because the ownerId is taken in as Number. Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
feat: add API package to register handlers in init scripts
…ss-8.5.12 Chore(deps): Bump postcss from 8.5.8 to 8.5.12
Bumps [actions/github-script](https://github.com/actions/github-script) from 8.0.0 to 9.0.0. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@ed59741...3a2844b) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: 9.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…ions/github-script-9.0.0 Chore(deps): Bump actions/github-script from 8.0.0 to 9.0.0
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 7.0.8 to 8.1.1. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v7.0.8...5f6978f) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-version: 8.1.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…er-evans/create-pull-request-8.1.1 Chore(deps): Bump peter-evans/create-pull-request from 7.0.8 to 8.1.1
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Bumps [cypress-io/github-action](https://github.com/cypress-io/github-action) from 7.1.9 to 7.2.0. - [Release notes](https://github.com/cypress-io/github-action/releases) - [Changelog](https://github.com/cypress-io/github-action/blob/master/CHANGELOG.md) - [Commits](cypress-io/github-action@783cb3f...b7a7441) --- updated-dependencies: - dependency-name: cypress-io/github-action dependency-version: 7.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.0 to 6.0.2. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v6...de0fac2) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…ress-io/github-action-7.2.0 Chore(deps): Bump cypress-io/github-action from 7.1.9 to 7.2.0
…ions/checkout-6.0.2 Chore(deps): Bump actions/checkout from 6.0.0 to 6.0.2
Signed-off-by: Joas Schilling <coding@schilljs.com>
feat(deps): Add Nextcloud 35 support on master
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/merge-viewer
branch
from
8a9e0e9 to
65b8a40
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/merge-viewer
branch
from
3a13166 to
6e00e09
Compare
Contributor
Author
|
What is you opinion on merging the Viewer into server? @AndyScherzinger @artonge @sorbaugh @skjnldsv Merge with full history (as shown here) is possible and does not increase server size a lot, but before I put more effort into finish up the merge (see last 8 commits to align code bases) I would like to know if this is something we want to have or if we stick with external repository. Target would be NC35+ and keep 34 and before in the external repository (stable branches) - that's why I ask this now directly after branch-off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Viewer is a force-enabled required app for quite some time, it must be installed when using Nextcloud.
To make developers life easier and to reduce duplicated assets ( 🚀 they can be shared now with other server apps) I merged the repository with the full history into the server.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)