fix(files): add name attribute to default view radio group#58752
fix(files): add name attribute to default view radio group#58752boris324 wants to merge 1 commit intonextcloud:masterfrom
Conversation
Add name="default_view" to the NcRadioGroup component so the underlying radio buttons are properly grouped. This enables keyboard navigation between radio options using arrow keys, improving accessibility. Fixes nextcloud#58729 Signed-off-by: boris324 <boris324@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
susnux
left a comment
There was a problem hiding this comment.
NcRadioGroup does not have such a property:
https://nextcloud-vue-components.netlify.app/#/Components/NcRadioGroup?id=ncradiogroup-1
Also it will then here be applied on a div HTML element which is invalid HTML.
It should be implemented for that component in the library (nextcloud-vue) first to properly pass it to the input element.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Closing due to lack of activity. |
Fixes #58729
Summary
Added
name="default_view"to theNcRadioGroupcomponent inFilesAppSettingsGeneral.vueso the underlying radio buttons are properly grouped with a sharednameattribute.This enables keyboard navigation between radio options using arrow keys, improving accessibility as described in the HTML radio button spec.
Test plan