Skip to content

fix(files): add name attribute to default view radio group#58752

Closed
boris324 wants to merge 1 commit intonextcloud:masterfrom
boris324:fix/radio-button-name-attribute
Closed

fix(files): add name attribute to default view radio group#58752
boris324 wants to merge 1 commit intonextcloud:masterfrom
boris324:fix/radio-button-name-attribute

Conversation

@boris324
Copy link

@boris324 boris324 commented Mar 6, 2026

Fixes #58729

Summary

Added name="default_view" to the NcRadioGroup component in FilesAppSettingsGeneral.vue so the underlying radio buttons are properly grouped with a shared name attribute.

This enables keyboard navigation between radio options using arrow keys, improving accessibility as described in the HTML radio button spec.

Test plan

  1. Open Files app settings
  2. Navigate to "Default view" radio buttons with keyboard
  3. Verify arrow keys now switch between "All files" and "Personal files"

Add name="default_view" to the NcRadioGroup component so the
underlying radio buttons are properly grouped. This enables
keyboard navigation between radio options using arrow keys,
improving accessibility.

Fixes nextcloud#58729

Signed-off-by: boris324 <boris324@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@boris324 boris324 requested review from a team and skjnldsv as code owners March 6, 2026 15:59
@boris324 boris324 requested review from nfebe and szaimen and removed request for a team March 6, 2026 15:59
@szaimen szaimen requested review from susnux and removed request for szaimen March 12, 2026 14:51
@szaimen szaimen added bug design Design, UI, UX, etc. 3. to review Waiting for reviews accessibility labels Mar 12, 2026
@szaimen szaimen added this to the Nextcloud 34 milestone Mar 12, 2026
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NcRadioGroup does not have such a property:
https://nextcloud-vue-components.netlify.app/#/Components/NcRadioGroup?id=ncradiogroup-1

Also it will then here be applied on a div HTML element which is invalid HTML.

It should be implemented for that component in the library (nextcloud-vue) first to properly pass it to the input element.

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@susnux
Copy link
Contributor

susnux commented Mar 21, 2026

Closing due to lack of activity.
Please add such prop first to nextcloud-vue :)

@susnux susnux closed this Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: add name attributes with matching valus to radio buttons to group them

4 participants