Open
Conversation
come-nc
reviewed
Mar 9, 2026
come-nc
reviewed
Mar 9, 2026
And deprecated OC_User::setPassword Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/oc_user
branch
from
a17fb20 to
8bc7f67
Compare
And replace most usages in Server with the newer APIs Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/oc_user
branch
from
8bc7f67 to
d89fdb4
Compare
CarlSchwan
requested review from
ArtificialOwl,
artonge,
salmart-dev and
sorbaugh
and removed request for
a team
artonge
reviewed
Mar 18, 2026
| protected static function setUserId(?string $uid): void { | ||
| $userSession = Server::get(IUserSession::class); | ||
| $userManager = Server::get(IUserManager::class); | ||
| if ($user = $userManager->get($uid)) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if ($user = $userManager->get($uid)) { | |
| $user = $userManager->get($uid); | |
| if ($user !== null) { |
| // simply skip updating the token when is it missing | ||
| } | ||
| } | ||
| if ($user = $userManager->get($uid)) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if ($user = $userManager->get($uid)) { | |
| $user = $userManager->get($uid); | |
| if ($user !== null) { |
| $password = $backend->getCurrentUserSecret(); | ||
| } | ||
| $user = $userSession->getUser(); | ||
| if ($user && $user->getUID() === $uid) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if ($user && $user->getUID() === $uid) { | |
| if ($user !== null && $user->getUID() === $uid) { |
| * @suppress PhanDeprecatedFunction | ||
| * @deprecated 34.0.0 This is internal, not to be used by apps | ||
| */ | ||
| public static function useBackend($backend = 'database') { |
Collaborator
There was a problem hiding this comment.
Unsure whether we can already remove useBackend and clearBackends. Does it respect our deprecation policy?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)