Skip to content

fix: handle submissions correctly when user wants to edit a given response#3269

Open
Chartman123 wants to merge 1 commit intomainfrom
fix/submissionHandling
Open

fix: handle submissions correctly when user wants to edit a given response#3269
Chartman123 wants to merge 1 commit intomainfrom
fix/submissionHandling

Conversation

@Chartman123
Copy link
Copy Markdown
Collaborator

@Chartman123 Chartman123 commented Apr 4, 2026

This fixes #3243 by adjusting the conditions. Also adds a missing check that the current user is allowed to see/edit the submission

Signed-off-by: Christian Hartmann chris-hartmann@gmx.de

@Chartman123 Chartman123 added bug Something isn't working php PHP related ticket javascript Javascript related ticket 3. to review Waiting for reviews regression Regression of a previous working feature security Security related ticket feature: 📊 responses & statistics labels Apr 4, 2026
@Chartman123 Chartman123 self-assigned this Apr 4, 2026
@Chartman123 Chartman123 changed the title fix(api): enforce submission visibility based on user permissions fix: handle submissions correctly when user wants to edit a given response Apr 4, 2026
@Chartman123
Copy link
Copy Markdown
Collaborator Author

/backport to stable5.2

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Apr 4, 2026
@Chartman123 Chartman123 force-pushed the fix/submissionHandling branch from ed10b27 to 876f1eb Compare April 4, 2026 13:32
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/Controller/ApiController.php 75.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

fix(submit): adjust conditional rendering for submission state

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123 Chartman123 force-pushed the fix/submissionHandling branch from 38705e1 to 1e9dd86 Compare April 4, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working feature: 📊 responses & statistics feature: 📝 submitting responses javascript Javascript related ticket php PHP related ticket regression Regression of a previous working feature security Security related ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User can't edit their submitted forms

1 participant