Write access over CalDAV by Jaggob · Pull Request #7655 · nextcloud/deck

Jaggob · 2026-02-18T13:36:12Z

Resolves: Write access over CalDAV #2399
Target version: main

Summary

This PR adds CalDAV write support for Deck, enabling CalDAV clients to create, update, complete/uncomplete, and delete Deck cards.

It also introduces per-user CalDAV list mapping modes in Deck settings, so each user can choose how Deck lists are represented in CalDAV clients:

Default (existing behavior): list hierarchy via VTODO parent/child relationships (RELATED-TO)
One VCALENDAR per list
Single board calendar with list name in CATEGORIES
Single board calendar with list position mapped to PRIORITY

Additional changes include DAV hardening and compatibility improvements (notably for Thunderbird and Apple clients), plus backend cleanup/performance improvements in the CalDAV handling path.

Done in this PR

Added CalDAV write support for Deck cards (create/update/delete/complete)
Added per-user CalDAV list mapping modes in Deck settings
Implemented category sync (CATEGORIES) including Thunderbird interoperability
Added DAV hardening and compatibility fixes (including stale href handling)

Future TODO

Improve move semantics further for clients that still use create+delete behavior instead of true move semantics. At the current implementation moving cards with e. g. Thunderbird leads to Nextcloud saying cards have been deleted and created instead of moved (but aside from activity logs moving works fine)
Add CalDAV mapping for assignees
Add CalDAV mapping for file attachments
Improve Apple tag interoperability where Deck tags are currently not recognized as native Apple tags

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Documentation (manuals or wiki) has been updated or is not required

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 36747a6fd3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

lib/DAV/DeckCalendarBackend.php

lib/DAV/Calendar.php

Implement first working write path for Deck CalDAV objects. - allow DAV write privilege on Deck calendars - handle PUT on existing card/stack ICS objects and map VTODO fields to Deck services - add NC32 compatibility fixes in BoardMapper for empty orX() usage - add unit tests for calendar update mapping Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Follow-up fixes after real-world macOS Reminders tests. - convert COMPLETED timestamps to DateTime expected by Deck entities - provide calendar object owner/group to avoid DELETE scheduling crashes - add backend tests for delete path and COMPLETED-without-STATUS mapping Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

…bility Stabilize bidirectional task sync for Apple Reminders and Thunderbird. - implement createFile support with stack resolution and alias normalization - support delete and robust completed mapping (STATUS/COMPLETED/PERCENT-COMPLETE) - add UID/resource-name upsert logic to avoid duplicates on move-back - handle board-to-board moves by updating existing deck-card IDs - export richer VTODO metadata (DTSTAMP/CREATED/LAST-MODIFIED/PERCENT-COMPLETE) - add extensive unit tests for update/create/delete and fallback paths Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

…Labels" This reverts commit 3d0af5c. Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

- fix Deck settings CalDAV mode selector rendering - make ETag/last-modified depend on selected list mapping mode - map list priority as left=9, right=1 for Thunderbird/Apple Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

…ateFile Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

grnd-alt

Hey, thanks for your contribution, would be nice to get this feature in. I have some smaller code-style remarks, that are partly up for discussion.

The most important remark is that one though: https://github.com/nextcloud/deck/pull/7655/changes#r2840797696

I think this should be oriented to work with tasks as much as possible before merging.

grnd-alt · 2026-02-19T12:48:18Z

lib/Service/CardService.php

+	 * @throws \OCP\AppFramework\Db\DoesNotExistException
+	 * @throws \OCP\AppFramework\Db\MultipleObjectsReturnedException
+	 */
+	public function findIncludingDeletedLite(int $cardId): Card {


As this function and findIncludingDeleted have basically the same logic as the existing find I would rather drop these and add 2 parameters to find:
bool includeDeleted = false
bool fullDetails = true
that way existing behavior stays the same and we have less duplicate code

grnd-alt · 2026-02-19T15:44:21Z

src/main.js

+	// register unused client for the sidebar to have access to its parser methods
+	const filesApi = window.OC && window.OC.Files
+	if (filesApi && typeof filesApi.getClient === 'function') {
+		Object.assign(window.OCA.Files, { App: { fileList: { filesClient: filesApi.getClient() } } }, window.OCA.Files)


this entire section is removed on main no need to re-add

grnd-alt · 2026-02-19T15:46:43Z

lib/Db/Stack.php

+		$lastModified->setTimestamp($lastModifiedTs);
+		$event->DTSTAMP = $lastModified;
+		$event->{'LAST-MODIFIED'} = $lastModified;
+		$event->STATUS = 'NEEDS-ACTION';


why is it always needs-action? Isn't it fine to have no status as the default?

grnd-alt · 2026-02-19T15:48:10Z

lib/Db/CardMapper.php

 	 */
-	public function findAllForStacks(array $stackIds, ?int $limit = null, int $offset = 0, int $since = -1): array {
+	public function findAllForStacks(array $stackIds, ?int $limit = null, ?int $offset = 0, int $since = -1): array {
+		$offset ??= 0;


grnd-alt · 2026-02-19T15:48:16Z

lib/Db/CardMapper.php

 	 */
-	public function findAll($stackId, ?int $limit = null, int $offset = 0, int $since = -1) {
+	public function findAll($stackId, ?int $limit = null, ?int $offset = 0, int $since = -1) {
+		$offset ??= 0;


why make $offset nullable and then set it back to non-null?

grnd-alt · 2026-02-19T16:01:10Z

lib/DAV/DeckCalendarBackend.php

 		return $this->boardService->findAll(-1, false, false);
 	}

+	/** @psalm-suppress InvalidThrow */


I don't see an InvalidThrow

grnd-alt · 2026-02-19T16:02:32Z

lib/DAV/DeckCalendarBackend.php

+			$card = null;
+			try {
+				$card = $includeDeleted
+					? $this->findCardByIdIncludingDeleted($cardId)


as said on the definition of findCardByIdIncludingDeleted this should just call find($cardId, $includeDeleted) imo

grnd-alt · 2026-02-19T16:09:41Z

lib/DAV/DeckCalendarBackend.php

+		return $this->stackService->find($stackId)->getCards() ?? [];
+	}
+
+	public function getCalDavListMode(): string {


grnd-alt · 2026-02-19T16:12:52Z

lib/DAV/DeckCalendarBackend.php

+
+	/** @return Card[] */
+	public function getChildrenForStack(int $stackId): array {
+		return $this->stackService->find($stackId)->getCards() ?? [];


I don't think we need this function

Especially as the only time this function is called $stack is already defined, so $stack->getCards() ?? [] in calendar.php works faster than retreiving the stack by id first

grnd-alt · 2026-02-23T13:12:32Z

lib/DAV/Calendar.php

@@ -95,45 +115,82 @@ protected function validateFilterForObject($object, array $filters) {
 	}

 	public function createFile($name, $data = null) {


I am not entirely fluent with the webdav protocol, but when testing this with nextcloud tasks and thunderbird the behavior was not as I would've expected it.
I could not investigate thunderbirds requests, but for nc tasks the createFile was called with a filename and after creation the same file was re-requested to display the task, the name seems not to be respected so it is not served again under that name leading to a 404.

github-actions · 2026-03-05T02:16:39Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Jaggob requested review from elzody, grnd-alt and luka-nextcloud as code owners February 18, 2026 13:36

Jaggob force-pushed the feature/cal-dav-write branch from 36747a6 to 31b37dd Compare February 18, 2026 13:42

chatgpt-codex-connector bot reviewed Feb 18, 2026

View reviewed changes

lib/DAV/DeckCalendarBackend.php Show resolved Hide resolved

lib/DAV/Calendar.php Show resolved Hide resolved

Jacob Bühler and others added 25 commits February 18, 2026 15:42

feat(caldav): map VTODO CATEGORIES to Deck labels

4a60d0c

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

fix(caldav): sync CATEGORIES with Deck labels for Thunderbird

8a36aa7

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

fix(deck): accept null offset in CardMapper findAll for stacks API

6b3279e

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

feat(caldav): add Apple Reminders tag mapping via X-APPLE-TAGS

52501d4

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

feat(caldav): add Apple tag fallback in DESCRIPTION via Deck-Labels

eea47cb

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Revert "feat(caldav): add Apple tag fallback in DESCRIPTION via Deck-…

163c92d

…Labels" This reverts commit 3d0af5c. Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

feat(caldav): add per-user list mapping modes for CalDAV

1b3a83b

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Refactor CalDAV update handling and remove experimental move reattach

46fdd6a

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Pass board context on delete and expose stable deck card id

6fac725

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Trigger CI

5574e74

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Stabilize CalDAV backend after review and CI feedback

84bfa95

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Harden CalDAV ACL and deleted-card lookup

5b80756

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Touch source board on cross-board card moves

b6a24e0

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Restore permissive CalDAV ACL for client move compatibility

f0f5bf5

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Fix CalDAV object name normalization for Thunderbird PUT/MULTIGET

ec53a1c

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Avoid PROPFIND failure on deck calendar children listing

73420ee

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Accept both card and deck-card names in CalDAV child lookup

7ed1309

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Fix CalDAV 412 on Thunderbird cross-board moves

e437983

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Harden CalDAV backend ACL and type handling

12a8211

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Decorate list VTODOs with category and priority

151eb81

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Harden CalDAV fallback handling and lightweight card lookups

6281cdd

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Jaggob added 11 commits February 18, 2026 15:42

perf(dav): reduce redundant lookups and serialization work

452fc61

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

fix(dav): avoid Thunderbird 404 on stale deck card hrefs

273d9d0

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

fix(dav): restrict placeholder resolution for write paths

482d109

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

fix(psalm): suppress unresolved Sabre symbols in DAV backend

faa776b

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

fix(frontend): guard optional OC.Files client bootstrap

8844852

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

test(dav): cover app-generated calendar URI normalization

12dec14

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

test(dav): cover in-progress status and Apple tags label sync

d5700ca

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

style(test): fix import ordering in dav backend tests

9faaef4

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

ci: use ubuntu-latest for fork pull-request workflows

875c711

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

chore(ci): drop workflow runner changes for upstream PR

c9333b7

Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

fix(dav): prevent trailing deletes on stack moves and restore via cre…

8f1393f

…ateFile Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>

Jaggob force-pushed the feature/cal-dav-write branch from 584dcf5 to 8f1393f Compare February 18, 2026 14:43

grnd-alt requested changes Feb 23, 2026

View reviewed changes

github-actions bot added the feedback-requested label Mar 5, 2026

		@@ -95,45 +115,82 @@ protected function validateFilterForObject($object, array $filters) {
		}

		public function createFile($name, $data = null) {

Conversation

Jaggob commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Done in this PR

Future TODO

Checklist

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

grnd-alt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Jaggob commented Feb 18, 2026 •

edited

Loading