Conversation
grnd-alt
force-pushed
the
fix/use-outside-click-deactivate
branch
2 times, most recently
from
83e71fd to
6b56593
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8284 +/- ##
==========================================
- Coverage 54.17% 54.09% -0.08%
==========================================
Files 104 104
Lines 3393 3398 +5
Branches 989 989
==========================================
Hits 1838 1838
- Misses 1317 1321 +4
- Partials 238 239 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/backport to stable8 |
grnd-alt
force-pushed
the
fix/use-outside-click-deactivate
branch
5 times, most recently
from
7604c35 to
a19546a
Compare
| focusTrap = createFocusTrap(appNavigationContainerElement.value!, { | ||
| allowOutsideClick: true, | ||
| clickOutsideDeactivates: (event) => { | ||
| if (isMobile.value && event.target instanceof HTMLInputElement) { |
There was a problem hiding this comment.
Why only on click on native inputs?
There was a problem hiding this comment.
Yeah, we have this issue also with clicking on AccountMenu in top-right and other elements
There was a problem hiding this comment.
@ShGKme to only close when focus will change, otherwise the navigation closes on every click that happens.
In reference to the screen recording the navigation would close when opening the right sidebar not when clicking on the user search.
I am also fine to always close on outside click if you prefer that?
There was a problem hiding this comment.
to only close when focus will change, otherwise the navigation closes on every click that happens.
IMHO this makes sense
There was a problem hiding this comment.
I would expect closing also without changed focus, e.g. navigation is covering chat/form/files list.
But it should respect popovers and dialogs open inside this navigation context (e.g. NcListItem with actions mounted inside NcApNavigation -> actions popover might be mounted to body, but it's still belong to the element inside of navigation
There was a problem hiding this comment.
tested around a bit more and to prevent cases like below It seems like it makes more sense to always close on clickOutSide, modals etc. are not considered clickOutside if they're mounted in the navigation so that will keep the navigation open.
Signed-off-by: grnd-alt <git@belakkaf.net>
grnd-alt
force-pushed
the
fix/use-outside-click-deactivate
branch
from
a19546a to
bfa53db
Compare
|
The backport to # Switch to the target branch and update it
git checkout stable8
git pull origin stable8
# Create the new backport branch
git checkout -b backport/8284/stable8
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick bfa53db3
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8284/stable8Error: Failed to check for changes with origin/stable8: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
5 participants
☑️ Resolves
Having the left sidebar (AppNavigation) and the right sidebar open at the same time and being on a mobile screen, causes the focus trap to block all focus. Clicks outside are allowed but focusing anything is not, so it is not possible to share on a small screen when both sidebars are shown.
🖼️ Screenshots
🏚️ Before (I am clicking on the input element the entire time)
screenrecording-2026-03-09_11-31-03.mp4
🏡 After
screenrecording-2026-03-23_15-39-55.mp4
🏁 Checklist
stable8for maintained Vue 2 version or not applicable