Skip to content

chore: prune completed unified-eval-schema docs#16

Merged
CybotTM merged 1 commit intomainfrom
chore/prune-completed-plan-docs
Apr 29, 2026
Merged

chore: prune completed unified-eval-schema docs#16
CybotTM merged 1 commit intomainfrom
chore/prune-completed-plan-docs

Conversation

@CybotTM
Copy link
Copy Markdown
Member

@CybotTM CybotTM commented Apr 29, 2026

Summary

Delete 2 dated docs whose implementation shipped:

  • docs/superpowers/plans/2026-04-16-unified-eval-schema.md
  • docs/superpowers/specs/2026-04-16-unified-eval-schema-design.md

skills/github-release/evals/evals.json contains both expectations (37) and assertions (37) per the unified schema, and validate-evals.sh accepts the new format. Git history preserves the docs.

Test plan

  • Verified evals.json contains both expectations and assertions fields
  • No remaining references to the deleted files outside their own contents

Plan implemented — preserved in git history:
- skills/github-release/evals/evals.json contains both `expectations` (37) and `assertions` (37) per the unified schema
- validate-evals.sh accepts the unified format
Copilot AI review requested due to automatic review settings April 29, 2026 09:03
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deletes the unified eval schema design specification and implementation plan. The reviewer recommends retaining these documents or moving the included conversion script to a shared directory, as the migration is still ongoing across other repositories and the information remains a critical reference.

I am having trouble creating individual review comments. Click here to see my feedback.

docs/superpowers/specs/2026-04-16-unified-eval-schema-design.md (1)

medium

This design specification defines the Unified Schema and validation rules intended for adoption across approximately 37 repositories. The Migration Path (lines 135-154) indicates that for most repositories, this is a Gradual process. Deleting this document while the migration is still ongoing for other repositories removes a critical reference for maintainers.\n\nIt is recommended to retain this specification until the migration is complete or until its contents are fully integrated into a permanent, non-dated documentation location (e.g., the skill-repo SKILL.md as suggested on line 141).

docs/superpowers/plans/2026-04-16-unified-eval-schema.md (341-404)

medium

This implementation plan contains a reusable Python conversion script (lines 341-404) designed to migrate legacy evals to the unified format. As the migration is still Gradual for other repositories (as noted in the associated design spec), this script remains highly relevant. Deleting it now may lead to duplicated effort across the organization.\n\nConsider moving the script to a shared utility directory (e.g., skills/skill-repo/scripts/convert-evals.py) before removing this plan.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes two dated “unified eval schema” planning/specification documents from docs/superpowers/ now that the unified schema work has shipped and the repository no longer references those docs.

Changes:

  • Delete the unified eval schema design spec doc (docs/superpowers/specs/2026-04-16-unified-eval-schema-design.md).
  • Delete the unified eval schema implementation plan doc (docs/superpowers/plans/2026-04-16-unified-eval-schema.md).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docs/superpowers/specs/2026-04-16-unified-eval-schema-design.md Removes an approved design/spec document that is now historical.
docs/superpowers/plans/2026-04-16-unified-eval-schema.md Removes an implementation plan document whose steps are now completed.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@CybotTM CybotTM merged commit 187f100 into main Apr 29, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants