Skip to content

fix: throw better error when ensrainbow fails to serve json #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shrugs merged 7 commits into from
Mar 5, 2026
Merged

fix: throw better error when ensrainbow fails to serve json #1713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
22592cc
fix: throw better error when ensrainbow fails to serve json
shrugs Mar 4, 2026
9268bbf
fix lint
shrugs Mar 4, 2026
610afc3
fix: streamline error derivation
shrugs Mar 4, 2026
3b8c13b
fix: lint
shrugs Mar 4, 2026
7c8f51d
Merge branch 'main' into fix/ensrainbow-not-found-handling
shrugs Mar 4, 2026
dd8ecdf
fix: revert pnpm exec
shrugs Mar 4, 2026
94f51a5
fix: more accurate ensraibow client config endpoint testing
shrugs Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions apps/ensindexer/src/lib/version-info.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,6 @@ import { existsSync, readdirSync, readFileSync } from "node:fs";
import { dirname, join } from "node:path";
import { fileURLToPath } from "node:url";

import { prettifyError } from "zod/v4";

import type { ENSIndexerVersionInfo, SerializedENSIndexerVersionInfo } from "@ensnode/ensnode-sdk";
import { makeENSIndexerVersionInfoSchema } from "@ensnode/ensnode-sdk/internal";

/**
* Get ENSIndexer version
*/
Expand Down
26 changes: 3 additions & 23 deletions packages/ensrainbow-sdk/src/client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,30 +317,10 @@ describe("EnsRainbowApiClient", () => {
expect(response).toEqual(configData);
});

it("should throw with server error message when response is not ok", async () => {
mockFetch.mockResolvedValueOnce({
ok: false,
statusText: "Internal Server Error",
json: () =>
Promise.resolve({
error: "Database not ready",
errorCode: 500,
}),
});

await expect(client.config()).rejects.toThrow("Database not ready");
});

it("should throw with fallback message when error body has no error field", async () => {
mockFetch.mockResolvedValueOnce({
ok: false,
statusText: "Service Unavailable",
json: () => Promise.resolve({}),
});
it("should throw with fallback message when error body is not valid JSON", async () => {
mockFetch.mockResolvedValueOnce({ ok: false, statusText: "Not Found" });

await expect(client.config()).rejects.toThrow(
"Failed to fetch ENSRainbow config: Service Unavailable",
);
await expect(client.config()).rejects.toThrow(/Not Found/);
});
});
});
Expand Down
5 changes: 1 addition & 4 deletions packages/ensrainbow-sdk/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,10 +400,7 @@ export class EnsRainbowApiClient implements EnsRainbow.ApiClient {
const response = await fetch(new URL("/v1/config", this.options.endpointUrl));

if (!response.ok) {
const errorData = (await response.json()) as { error?: string; errorCode?: number };
throw new Error(
errorData.error ?? `Failed to fetch ENSRainbow config: ${response.statusText}`,
);
throw new Error(`Failed to fetch ENSRainbow config: ${response.statusText}`);
}

return response.json() as Promise<EnsRainbow.ENSRainbowPublicConfig>;
Expand Down
Loading