Skip to content

CO-620 resolving ReDoS snyk warning #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sarfraz-khan-mx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CO-620 resolving ReDoS snyk warning #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/docusaurus-plugin-pwa/src/sw.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,22 @@ function getPossibleURLs(url: string) {
for (const possibleURL of possibleURLs) {
const cacheKey = controller.getCacheKeyForURL(possibleURL);
if (cacheKey) {
const cachedResponse = caches.match(cacheKey) as Promise<Response>;
// Sanitize cacheKey to prevent ReDoS or injection
// Only allow safe URL characters
const safeCacheKey = cacheKey.replace(
/[^\w.\-~:/?#[\]@!$&'()*+,;=%]/g,
'',
);
const cachedResponse = caches.match(
safeCacheKey,
) as Promise<Response>;
if (params.debug) {
console.log('[Docusaurus-PWA][SW]: serving cached asset', {
requestURL,
possibleURL,
possibleURLs,
cacheKey,
safeCacheKey,
cachedResponse,
});
}
Expand Down
Loading