Skip to content

Move upload source step after details in submission flow#24589

Merged
willdurand merged 1 commit intomasterfrom
move-source-code-to-end-of-flow
Mar 24, 2026
Merged

Move upload source step after details in submission flow#24589
willdurand merged 1 commit intomasterfrom
move-source-code-to-end-of-flow

Conversation

@willdurand
Copy link
Copy Markdown
Member

@willdurand willdurand commented Mar 12, 2026

Fixes mozilla/addons#16133


In addition to changing the order of steps, I had to update a message. Indeed, we currently show a "remember" message conditionally in the "details" step:

Screenshot 2026-03-12 at 11 35 26

In this patch, I replaced it with a different message since the source code is uploaded after:

Screenshot 2026-03-12 at 10 53 25

@willdurand willdurand force-pushed the move-source-code-to-end-of-flow branch 3 times, most recently from 47cf88d to 27e9f23 Compare March 18, 2026 13:17
@willdurand willdurand marked this pull request as ready for review March 18, 2026 13:31
@willdurand willdurand requested review from a team and eviljeff and removed request for a team March 18, 2026 13:31
Copy link
Copy Markdown
Member

@eviljeff eviljeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc about copy change

Comment thread src/olympia/devhub/templates/devhub/addons/submit/describe.html Outdated
Comment thread src/olympia/devhub/templates/devhub/addons/submit/describe_minimal.html Outdated
@abyrne-moz
Copy link
Copy Markdown

Given that the add-on builder tries to build the code, it seems like they might not need to provide instructions anymore, so this feels acceptable to me.

Copy link
Copy Markdown
Member

@wagnerand-moz wagnerand-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ for the updated copy about providing source code building instructions.

@willdurand willdurand force-pushed the move-source-code-to-end-of-flow branch from 27e9f23 to b1408c1 Compare March 24, 2026 11:40
@wagnerand-moz
Copy link
Copy Markdown
Member

Given that the add-on builder tries to build the code, it seems like they might not need to provide instructions anymore, so this feels acceptable to me.

Once the builder is rolled out we probably need to change this and other copy as well, both on AMO and in other places (e.g. extension workshop). Instructions still need to be provided, but in a very different form. We have some ideas but haven't talked in depth yet what that would look like. One requirement we already know today is that they need to be machine-readable, so it could be as simple as a rpm run target we define.

@willdurand willdurand merged commit 83601b9 into master Mar 24, 2026
45 checks passed
@willdurand willdurand deleted the move-source-code-to-end-of-flow branch March 24, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Move upload source step after details in submission flow

4 participants