Continue OAuth discovery on non-JSON metadata responses#2171
Open
FU-max-boop wants to merge 1 commit into
Open
Continue OAuth discovery on non-JSON metadata responses#2171FU-max-boop wants to merge 1 commit into
FU-max-boop wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 3678ce5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
FU-max-boop
force-pushed
the
fix/oauth-discovery-non-json-fallback
branch
from
dc32a08 to
fe542d6
Compare
FU-max-boop
force-pushed
the
fix/oauth-discovery-non-json-fallback
branch
from
fe542d6 to
3678ce5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2126.
discoverAuthorizationServerMetadata()currently treats any HTTP 200 discovery response as parseable metadata. If the RFC 8414 candidate endpoint returns an HTML/static page,response.json()throws and the SDK never tries the later OIDC discovery URLs.This catches non-JSON bodies for successful discovery responses and continues to the next OAuth/OIDC metadata candidate, preserving existing behavior for 4xx/502 fallback and non-502 5xx errors.
Tests
npx -y pnpm@10.26.1 --filter @modelcontextprotocol/client test -- auth.test.tsnpx -y pnpm@10.26.1 --filter @modelcontextprotocol/client lintnpx -y pnpm@10.26.1 --filter @modelcontextprotocol/client typechecknpx -y pnpm@10.26.1 --filter @modelcontextprotocol/client buildnpx -y pnpm@10.26.1 run sync:snippets --check