fix(client): preserve custom Accept headers in StreamableHTTPClientTransport#1655
Open
nielskaspers wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Conversation
…ansport The SDK unconditionally overwrites custom Accept headers provided via requestInit.headers with its own defaults. This prevents users from configuring MCP servers that require specific Accept header values. Only set default Accept headers when the user has not provided one. Fixes modelcontextprotocol#1646
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamableHTTPClientTransportunconditionally overwrites customAcceptheaders provided viarequestInit.headerswith SDK defaults. This change only sets the defaultAcceptheader when the user has not already provided one.Issue
Fixes #1646
Changes
send()(POST requests): only setaccept: application/json, text/event-streamif no Accept header exists_startOrAuthSse()(GET SSE requests): only setaccept: text/event-streamif no Accept header existsTesting