fix(client): add Accept header in SSEClientTransport.send()#1654
Open
ss19901101 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(client): add Accept header in SSEClientTransport.send()#1654ss19901101 wants to merge 1 commit intomodelcontextprotocol:mainfrom
ss19901101 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
SSEClientTransport's send() method was missing the Accept header when making POST requests. This caused issues with MCP servers that require 'Accept: application/json, text/event-stream' header. The fix aligns SSEClientTransport with StreamableHTTPClientTransport, which already sets this header correctly. Fixes compatibility with servers like Zhipu's MCP that strictly enforce the Accept header requirement.
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SSEClientTransport's send() method was missing the Accept header when making POST requests to MCP servers. This caused compatibility issues with MCP servers that strictly require the
Accept: application/json, text/event-streamheader for Streamable HTTP transport.Solution
Added the Accept header in SSEClientTransport.send() method to match the behavior of StreamableHTTPClientTransport:
Testing
Comparison
This aligns the two transports and improves MCP server compatibility.