Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/client/src/client/sse.ts
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,10 @@ export class SSEClientTransport implements Transport {

async close(): Promise<void> {
this._abortController?.abort();
this._abortController = undefined;
this._eventSource?.close();
this._eventSource = undefined;
this._endpoint = undefined;
this.onclose?.();
}

Expand Down
1 change: 1 addition & 0 deletions packages/client/src/client/streamableHttp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,7 @@ export class StreamableHTTPClientTransport implements Transport {
this._reconnectionTimeout = undefined;
}
this._abortController?.abort();
this._abortController = undefined;
this.onclose?.();
}

Expand Down
28 changes: 28 additions & 0 deletions packages/client/test/client/sse.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1528,4 +1528,32 @@ describe('SSEClientTransport', () => {
expect(globalFetchSpy).not.toHaveBeenCalled();
});
});

describe('Transport lifecycle', () => {
it('should allow start() after close() for transport reuse', async () => {
transport = new SSEClientTransport(resourceBaseUrl);
await transport.start();

// close() the transport
await transport.close();

// Second start() should succeed — not throw "already started"
await transport.start();

// Verify transport is functional by sending a message
const message: JSONRPCMessage = {
jsonrpc: '2.0',
method: 'test',
params: {},
id: 'test-1'
};

await transport.send(message);

// Wait for request processing
await new Promise(resolve => setTimeout(resolve, 50));

expect(lastServerRequest.method).toBe('POST');
});
});
});
37 changes: 37 additions & 0 deletions packages/client/test/client/streamableHttp.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1659,4 +1659,41 @@ describe('StreamableHTTPClientTransport', () => {
});
});
});

describe('Transport lifecycle', () => {
it('should allow start() after close() for transport reuse', async () => {
const fetchMock = globalThis.fetch as Mock;

// First start()
await transport.start();

// close() the transport
await transport.close();

// Second start() should succeed — not throw "already started"
await transport.start();

// Verify transport is functional by sending a message
fetchMock.mockResolvedValueOnce({
ok: true,
status: 200,
headers: new Headers({ 'content-type': 'application/json' }),
json: async () => ({
jsonrpc: '2.0',
result: {},
id: 'test-1'
})
});

const message: JSONRPCMessage = {
jsonrpc: '2.0',
method: 'test',
params: {},
id: 'test-1'
};

await transport.send(message);
expect(fetchMock).toHaveBeenCalledTimes(1);
});
});
});
Loading