mcp: add ErrorHandler to ServerOptions#865
Open
ravyg wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
mcp: add ErrorHandler to ServerOptions#865ravyg wants to merge 1 commit intomodelcontextprotocol:mainfrom
ravyg wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Add an optional ErrorHandler callback to ServerOptions for receiving out-of-band errors that occur during server operation. These include keepalive ping failures, notification delivery errors, and internal JSON-RPC protocol errors. When ErrorHandler is nil, errors continue to be logged at the appropriate level using the configured Logger. Fixes modelcontextprotocol#218
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional ErrorHandler callback to ServerOptions for receiving
out-of-band errors that occur during server operation but are not
associated with a specific request.
Error sources wired to the handler:
When ErrorHandler is nil, existing behavior is preserved — errors are
logged at the appropriate level.
Thanks to @findleyr and @jba for the design discussion on this issue.
Fixes #218