mcp: preserve existing Content in SetError#864
Open
ravyg wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
mcp: preserve existing Content in SetError#864ravyg wants to merge 1 commit intomodelcontextprotocol:mainfrom
ravyg wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
SetError now only populates the Content field when it has not already been populated (len check handles both nil and empty slice). This allows callers to provide a user-friendly message while still recording the underlying error for middleware inspection via GetError. Fixes modelcontextprotocol#858
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetError now only populates the Content field when it has not already
been populated. This allows callers to provide a user-friendly message
while still recording the underlying error for middleware inspection
via GetError.
The len check (rather than nil check) ensures both nil and empty-slice
Content are treated as "not yet populated."
Fixes #858