Skip to content

auth: issuer mix-up mitigation#859

Open
max-stytch wants to merge 1 commit intomodelcontextprotocol:mainfrom
max-stytch:max/SEP-2468
Open

auth: issuer mix-up mitigation#859
max-stytch wants to merge 1 commit intomodelcontextprotocol:mainfrom
max-stytch:max/SEP-2468

Conversation

@max-stytch
Copy link
Copy Markdown

This PR functions as a Reference implementation of SEP-2468 / RFC9207.

This PR hardens the MCP OAuth Client functionality against Mix-Up attacks:

Mix-up attacks aim to steal an authorization code or access token by
tricking the client into sending the authorization code or access
token to the attacker instead of the honest authorization or resource
server

This PR hardens the client by adding support for a new iss parameter in authorization responses:

  • Authorization Servers broadcast support for the iss parameter via the authorization_response_iss_parameter_supported metadata parameter
  • If the parameter is supported, clients expect to receive the iss parameter in the authorization response
  • Clients compare the iss parameter in the authorization response to the Issuer parameter in the authorization metadata. The two must match exactly for the response to be processed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant