Open
Conversation
Member
|
@jfclere Please review. |
rhusar
requested changes
Apr 20, 2026
Member
rhusar
left a comment
rhusar
left a comment
There was a problem hiding this comment.
Using %ld is not fully portable. The fix should use APR_INT64_T_FMT instead.
See native/advertise/mod_advertise.c for example.
Member
Author
Good point. Fixed everywhere in the latest commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
restart_timeis of typeapr_int64_t, so(int)is not correct (it leads to ugly numbers)