constraintenforcer: ignore completed tasks in reservation accounting#3237
Open
lohitkolluri wants to merge 1 commit into
Open
constraintenforcer: ignore completed tasks in reservation accounting#3237lohitkolluri wants to merge 1 commit into
lohitkolluri wants to merge 1 commit into
Conversation
Completed tasks (especially from replicated-job history) should not consume node reservations in the constraint enforcer. Add a regression test covering completed job tasks. Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
Author
|
Quick sync note: this change is the upstream fix for the behavior reported in moby/moby#52652. |
This was referenced May 28, 2026
Member
|
@dperny care to have a look? |
Author
|
@dperny Can you check it out and drop suggestions if any? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Fixes moby/moby#52652