Add fftfreq, rfftfreq and scalar axes for fftshift/ifftshift#3298
Merged
angeloskath merged 5 commits intoml-explore:mainfrom Apr 1, 2026
Merged
Add fftfreq, rfftfreq and scalar axes for fftshift/ifftshift#3298angeloskath merged 5 commits intoml-explore:mainfrom
angeloskath merged 5 commits intoml-explore:mainfrom
Conversation
Member
|
That looks good but can you add it to the C++ side as well and then call it from python? |
Contributor
Author
|
Thanks for looking at this. Have now moved fftfreq and rfftfreq to the C++ side. |
angeloskath
approved these changes
Apr 1, 2026
Member
angeloskath
left a comment
There was a problem hiding this comment.
Looks great. I 'll merge after the tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add
fftfreqandrfftfreqtomlx.core.fft, and allowfftshift/ifftshiftto accept a scalarintfor theaxesparameter to match NumPy's API.Checklist
pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes