Fixed headers being printed when using SaveAsAsync despite ExcelIgnore property set to true on DynamicExcelColumn

[michelebastione]

As pointed out in #584

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the MiniExcel library where columns marked with ExcelIgnore were still being included in the output when using the SaveAsAsync method with DynamicExcelColumn. The changes ensure that the ExcelIgnore property is correctly honored during both header printing and data retrieval, preventing unwanted columns from appearing in the generated Excel files. A new comprehensive test case has been added to prevent regressions.

Highlights

• Bug Fix: Resolved an issue where the ExcelIgnore property on DynamicExcelColumn was not respected when using SaveAsAsync, leading to ignored headers being printed.
• Header Printing Logic: Updated the PrintHeaderAsync method to explicitly check and skip columns marked with ExcelIgnore.
• Data Retrieval Logic: Modified GetRowValuesAsync to ensure that data for ExcelIgnore columns is not processed or yielded.
• Test Coverage: Added a new asynchronous test case (TestIssue584) to validate the correct behavior of ExcelIgnore with dynamic columns during SaveAsAsync.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue where headers for ignored columns were being printed. The changes in ExcelOpenXmlSheetWriter.Async.cs and AsyncEnumerableWriteAdapter.cs aim to respect the ExcelIgnore property. My review found a potential issue with cancellation handling and a bug in the logic for handling ignored columns in AsyncEnumerableWriteAdapter, which could lead to incorrect output. I've provided suggestions to address these points.