Merge changes from the latest ANGLE version whilst preserving modifications#5
Open
mrjasonn wants to merge 2077 commits intominecraft-linux:metal-freezefrom
Open
Merge changes from the latest ANGLE version whilst preserving modifications#5mrjasonn wants to merge 2077 commits intominecraft-linux:metal-freezefrom
mrjasonn wants to merge 2077 commits intominecraft-linux:metal-freezefrom
Conversation
450d23d to
d3bfe55
Compare
Also includes a test for a bug with an existing AST translation that is no longer necessary, and a tiny fix for the recent GLSLTest_ES31.ShortCircuitOutOfBoundsAccess/ES3_1_OpenGLES test. Bug: angleproject:349994211 Bug: angleproject:42261112 Change-Id: I387e746dfdc6f6520d17a416dc0225d96c69e896 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7225142 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
https://chromium.googlesource.com/vulkan-deps.git/+log/7d1d0f981647..9f7342ee3761 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/53ead8fa37722785bf478689c78bab8f01dc1797..0036567adc7961f55a65a518bf5e303a4d4650c4 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/940d4850f12cef87336b94fee4b7eaf9ca394222..49a8b7cd70fb8b62f920bb72091b73123d6cd28f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/0db9a0d55e33f8b63b733f37dc59eb441d51abf0..002a13d8f9bcca69e4efc7911492c4ac1c981698 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/58e180275fe6c135987e51c970bf1d8d9d2ef89b..010ea35d049edec185afb1855b7b9c2c36d96ad8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ic041fde0f7be689fe0a15a8ebe02ab9caee7f505 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7245831 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
bgraTexImageFormatsBroken appears to be specific to the proprietary driver. Bug: b/467269963 Test: no chrome gpu process crash on trogdor on boot Change-Id: Ied31f8b4c2f5916f0f414f43fbe7eed8541a5e96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7241220 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/98e307118c58..c6a8928b4f43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cf9d55d661..a1ca27337a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fc67fc1cee..d7c2ffbac2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5a96fadd74..f6250034e0 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/adabe6e669..7f067958af * third_party/android_build_tools/error_prone/cipd: u3Ysea5yvF7JG-0gnp4dKcVL1FprxVeFWOrHZez_OSQC..kRNnsWXC3hVFeKVr_y5t203iFi5ioOwmy0i09YvhD0UC * third_party/android_build_tools/lint/cipd: WQwX5xvIym8Yib4WwgcJekV-Soj0djYnW6AXwKzwI4YC..uQHIYETb_gUqkNty6IBU9itaWibGZv-_gQFejZhtu_4C * third_party/android_build_tools/manifest_merger/cipd: 9e2lYzfL-ltYnilrRBiHQ4fLOXmdaatw6oHGU5yJNg4C..Vu2o1jtYofux3WRxM75ij546NrJDgTk3C5SmxHjUNVUC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/b37cc84c9e..d372680c8a * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4c6437f269..ecbf89e1da * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e82038b2e9..c5dd8ade97 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/88fc07ed14..ef486348f6 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/d290e1131d..8b4e75b574 * third_party/siso/cipd: git_revision:49dcca5d2be985d8ac6d512e59ee59e315264fb8..git_revision:6839895535a2a5e91fb3ddfae03e95aded998244 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/748a0e7eae..d6ba568c60 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c4ec0ba761..3dc78ffad8 No update to Clang. Bug: None Tbr: abdolrashidi@google.com,ynovikov@google.com Change-Id: Icdbd3e2c5c15e5379cd2770a543b812289bd7e83 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7247656 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
The getData() method returns a const-ref, and a move from such silently degrades to a copy. Instead, implement a takeData() method, and adjust callers appropriately. I noticed this today, but this was also hit some time ago but never acted upon in the linked bug. Bug: chromium:364788123 Change-Id: Id2468c5d5f26e5f7df0ca50c8466588487219b58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7241216 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
These were missed when the new angle::Span code was introduced. Without these, std::string and std::string_view do not implicitly convert to angle::Span as expected. Then correct construction from std::array<> to allow construction from any convertible array type. -- Add missing include for <vector> as std::vector is mentioned in span.h. This is theoretically wrong, although clang doesn't give a warning until such a deduction is required. Bug: angleproject:436880895 Change-Id: I787326d7887f6f17813d8705702741ddbf0fcea0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7242831 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Adding more feature flag overrides to configs is starting to go beyond the 256-character limit of lucidb. Bug: angleproject:447633563 Change-Id: Ia735a0938dd081d643fcd56b6b34be44f751d495 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7247567 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Replace string comparison with boolean flag for checking cl_arm_non_uniform_work_group_size extension support. This follows the established pattern used for other extensions. Bug: angleproject:381335059 Change-Id: I8d745d49727634ccc14d6315ebcd2bafc7a1d4f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7237883 Reviewed-by: Austin Annestrand <a.annestrand@samsung.com> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
See also https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38825 Bug: angleproject:42267038 Change-Id: I7b549b9130d439dde6d73723d1c27f8680234dce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7242988 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Add an end2end test to show that glTexStorage2D will fail with paletted formats. Bug: angleproject:466888667 Change-Id: I005fc7431a53c452a92334da94341842db691bbe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7242924 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Aurora Zhang <Aurora.Zhang@arm.com>
Get a baseline to ensure things are less likely to break during the spanification process. Bug: angleproject:436880895 Change-Id: I6cf99fc800556885412a0b3cb21affda27a17695 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7248659 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
https://chromium.googlesource.com/chromium/src.git/+log/c6a8928b4f43..c09ec777827c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a1ca27337a..c0fe27e349 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d7c2ffbac2..797cad2655 * buildtools/linux64: git_revision:5964f499767097d81dbe034e8b541c3988168073..git_revision:4e0818fd86bffc0b4a4b61d3295a6732ba08d715 * buildtools/mac: git_revision:5964f499767097d81dbe034e8b541c3988168073..git_revision:4e0818fd86bffc0b4a4b61d3295a6732ba08d715 * buildtools/win: git_revision:5964f499767097d81dbe034e8b541c3988168073..git_revision:4e0818fd86bffc0b4a4b61d3295a6732ba08d715 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f6250034e0..c20bd7f8c6 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/7f067958af..3684ae205a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e617119e2c..ea58ca8d0f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ecbf89e1da..cd4db8fd7f * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/c5dd8ade97..b4596f1d2b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/09bd4890d9..82e9daa584 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3dc78ffad8..b3d6771239 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I3ce40b992ea619614a9be79d45cf330c26664ee7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7247340 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/9f7342ee3761..f23836d62fa0 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/6146b3d9ad4fcc5fb512209d348e97ce03749169..e8f037b983727d4b433bd9c7a6be453b4dd9c108 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/49a8b7cd70fb8b62f920bb72091b73123d6cd28f..1c26ea1cf595ae0aa86b1740c84ffadf30d08f2f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/010ea35d049edec185afb1855b7b9c2c36d96ad8..f18115358d095496cbe3f703786b1ab1c39ff5af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I43897ab2d549d1da30dae2f0470e87c0bd4ae9e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7250496 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bug: angleproject:397474813 Bug: angleproject:467875813 Change-Id: I4d5143699ec11dff26b98a77a2cbdf9dbda589a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7251714 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: mohan maiya <m.maiya@samsung.com>
Remove per-file pragma, and mark the function templates in this file as safe, since they all use compiler-deduced sizes which do not allow the caller to specify a mistaken size. These may be reasonable alternatives to marking every memset/memcpy in the code as UNSAFE. -- Introduce StructCopy() function. -- Tidy WrappedArray while at it. Bug: angleproject:436880895 Change-Id: I7607824799ccc48a1172fb631c7c090be1565ea2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7247250 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
For depth stencil format that has emulated channel, we always clear the emulated channel. This means the emulated channel will always have mVkImageContentDefined bit set. When we query isVkImageContentDefined(), we really only care about user content. This CL makes it so that we ignore the emulated channel's mVkImageContentDefined. This mainly relevant for depth stencil format which we track content defined separately for depth and stencil channel. For colors that has emulated channel we don't track emulate channel separately so we always return mVkImageContentDefined. This fixes the capture_replay_tests bot failure. Bug: b/447633563 Change-Id: I2961d5a703c6f15eea151b8c849ba85d0be4aa2c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7241217 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
A stray const is again silently degrading the move to a copy. Bug:chromium:364788123 Change-Id: Ie6b27df64ab235729c164bc7663ad46bb0b2dce3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7247254 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Tom Sepez <tsepez@chromium.org>
Create a new BlockLayoutEncoder PackedSPIRVBlockEncoder for packing default uniforms on vulkan backend tighter. When convertLowpAndMediumpFloatUniformsTo16BitsThis feature is enabled, ProgramVk uniform encoder and SPIRV translator encoder are set to use this new PackedSPIRVBlockEncoder for calculating the offset of each member within the default uniform block. The implementations of the PackedSPIRVBlockEncoder are placeholder functions for now and they work the same as std140BlockEncoder, so this change should be no op. Bug: angleproject:405795981 Change-Id: Ia7f3d6594c8666e5610d38c9d2cf0096fa0c2600 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7200889 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
When ESSL 100 shaders using GL_WEBGL_video_texture run on the OpenGL backend (desktop GL), compilation fails with "no function with name 'texture2D'" error. Root cause: textureVideoWEBGL() was always translated to texture2D() regardless of the target GLSL version. When targeting GLSL 130+, texture2D() doesn't exist (replaced by texture()), causing the error. Bug: angleproject:466412253 Change-Id: I1480e30c863bdfaf3bfc06dc85ff22ec4e96b55d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7252470 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Adding more feature flag overrides to configs is starting to go beyond the 256-character limit of lucidb. This CL uses abbreviation to shorten the configuration strings for IncompatibleTextureTest Bug: angleproject:447633563 Change-Id: I64d82dcded503fc14247ffab71df2c3f15e75e80 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7252892 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Bug: angleproject:42266263 Change-Id: I5905c4c08566f7dfcb360d970cb0715bd4958c8b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7486431 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Resolve unsized CopyTexImage2D formats using GL_UNSIGNED_BYTE and drop framebuffer type from GetCopyTexImageImageFormat. Bug: angleproject:42264866 Change-Id: Id6441f88f19a44c4deab1c784e2ba0f92274a715 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7264366 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
The export_targets presubmit asserted when GN deps included executable or action_foreach targets (e.g. Dawn's clang-tblgen and dxcetw-h). Treat these as expected types so dependency traversal succeeds and the warning goes away for synced checkouts. Bug: angleproject:477541767 Change-Id: Idba093c7c388f2aabdc77a187f5e30a780b1d518 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7504016 Auto-Submit: Aaron Teo <hocheung@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Removes the old generated LUCI content that was directly in //infra/config/generated since the files are now read from //infra/config/generated/luci. Also adds various chromium-luci-related configs to main.star. These do not currently have any effect (except for the list of generated files to keep), but will be necesasry in order to add builders using chromium-luci in the future. Bug: angleproject:475260235 Change-Id: Icd2ee56ea3279380ecb7d0bbb337a756ac576171 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7506215 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Make `import("//build/config/gclient_args.gni")` conditional,
since Skia does not have `build`.
Bug: angleproject:465787212
Change-Id: I829808d7f90fc88d46321a6722a153b365a08eb0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7511412
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
For GLSL built-in attributes, ANGLE should not assign locations to them. If we assign locations to them, link program would fail when we have built-in attributes and GL_MAX_VERTEX_ATTRIBS number of vertex attributes. An end2end test is also added. Bug: angleproject:475587478 Change-Id: I2817f61164bbb7be48e7c837a56141d20ae3f4b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7470090 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
The shadow memory introduction modifies the return value of mapBufferRange() regardless frame capture feature is enabled or not. This potentially slows down the ANGLE runtime. Move the return value modification of mapBufferRange() one layer up to its entry point. The implementation involves updating the entry point generation script, and guarding the frame capture logic with ANGLE_CAPTURE_ENABLED flag to not compile the code in production builds. Bug: b/42266294 Test: built w/ and w/o frame capture feature Test: ran a trace w/o seeing any problem Change-Id: I6184b2b6ebeb8bfd98fbedb8ee660d71ec647299 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7240952 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Merck Hung <merckhung@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
This CL fixes a bug in the deferred clears optimization. Currently, only clear calls actually check if there are any clear operations in mDeferredClears, and flush out the queue if so. However, we need to ensure that whenever syncState() is called on the framebuffer for any operation, that there are no clears in the deferred queue. Therefore, operations like draw, blit, etc also need to check if there are clear operations and either restage them, or no-op them. This change modifies startNewRenderPass so that draw calls can flush out the deferred clears queue, and also fixes a bug where flushDeferredClears did not actually reset the queue. Bug: angleproject:476134798 Change-Id: Ic4e724128a55595ab84d3e0609bfd11ee887303c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7485951 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
https://chromium.googlesource.com/chromium/src.git/+log/e8f5467e80a7..daa40f9aa676 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c005383938..73bc49ded0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c636857855..7f20584b3b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/1597226b82..874fd0e155 * third_party/android_build_tools/error_prone/cipd: I1le-VKG1eHuZsz0Lls-JSp9FI1adQfL0oia5LC9kaEC..jum1S30anLAjV7GCe6k2X00_DFwQYvR-YF2iOvXN4GwC * third_party/android_sdk/public: nClDjKPpactQ8aQZF5rHwD-wuSp0RXLzKy9ORun0p4wC..LZa8CWNVWS6UUQgQ7IJdFCqRV1Bmx2-alTNqEDJpJkcC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f5cc226ca9..f0bcc24b23 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f09d6283fc..0407d6b160 * third_party/libdrm/src: https://chromium.googlesource.com/chromiumos/third_party/libdrm.git/+log/ad78bb591d..369990d966 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/5015187a42..56152c7943 * third_party/re2/src: https://chromium.googlesource.com/external/github.com/google/re2.git/+log/e7aec59850..972a15cedd * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/8d3fa79a52..808ee5802f * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/97e19de6f6..1d6b7f00eb * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/486bee522c..1fc5adbbce * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c2726e282b..837ddf8a78 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/42f11b881f..d2fadac996 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I4b30a0327c2a32eba8fb7843b6dcc9b5cab713e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7512731 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/ae18e4e9f317..cf6f449e02cd Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/42b0ef1ddb872ddb5183efecd712944c279baf48..f0bd0257c308b9a26562c1a30c4748a0219cc951 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/dfc5ab82cdf83c6b7ae3bc4198822c130df6f2a6..fbe4f3ad913c44fe8700545f8ffe35d1382b7093 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/0007545ec811852c8ea6154f201624583c88563f..5d94bb4dcc968cccce1f601324fcaf3eda92a52b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/28a23dbbb1445af12a62a42675cf378e66f6cc17..cde39136de2fef536e915d6f002608e42a7409d7 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/983f86f9b5f5de9ce37349f42c38d6418218126f..5ebf9cb185ee2caf429a5e9b6fabb9a2b5fa8a1d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/0d5c138f5019ee58be2ba7aed6e82345fd1ddab9..9a5001916ccc34f9d0facf084790e3778c70c3f8 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/711102e97df4bbbb8627089ea1745f3b5b02acca..23f2b61bd62cd934043bbc77dfb47b150f839ef6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I43008d320e07700140c6aa7c9d7cd35d6728667b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7512732 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
since we have everything we need to do this during kernel creation. this also allows us to look into potentially creating the compute pipeline during kernel creation if we can later remove the dependency of WGS being tied to a specialization constant. Bug: angleproject:477255459 Change-Id: I266ad514c67194951442fe7bbd8b469686e9265b Signed-off-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7498932 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
asphalt_9 has a usage pattern that it starts render pass with clear and then do the blit and then keep rendering. Right now because we picked blitWithCommands, we end up having to endRenderPass and then blit and then startRenderPass again. This CL detects midRenderPass blit and bit by drawing a textured quad, before try with blitWithCommands. This way we reduces render pass from 3 to 1. A test is added to ensure we don't regress in future. Bug: b/470414028 Change-Id: Id35233eb7e4862f7a2419474b648711bfcd9d830 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7489541 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: angleproject:362486580 Change-Id: I22818e4b31d7bac3b1adf440f7b2c4b38ab5141a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7510813 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Currently the feature flag useVertexInputBindingStrideDynamicState
is used to indicate support for BindVertexBuffers2. In the process of
expanding BVB2 usage (CL:6944912), the condition for this flag was
changed so it could be enabled alongside dynamic vertex input for BVB2
usage, although the stride would still be set by the latter feature,
making the former unnecessary.
This change aims to split the BindVertexBuffers2 support from the vertex
input binding stride feature.
* Added separate feature flag: supportsBindVertexBuffers2
* Currently enabled with supportsExtendedDynamicState.
* It has replaced useVertexInputBindingStrideDynamicState wherever
necessary.
* Updated useVertexInputBindingStrideDynamicState to be disabled with
supportsVertexInputDynamicState once again.
* (VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE no longer added
alongside VK_DYNAMIC_STATE_VERTEX_INPUT_EXT)
* Updated getPipelineSubsetMemory() in pipeline desc so vertex input
dynamic state takes precedence over binding stride.
* In addition, assertion is added to make sure they are not enabled
at the same time.
Bug: angleproject:474385503
Change-Id: I598f4fe8507e6da29d660c34d03d3de6fc613f94
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7508014
Reviewed-by: Charlie Lao <cclao@google.com>
Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Bug: angleproject:42266894 Change-Id: Icbfc655589ab2fe5e281a65a61a2f7def0de8594 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7509580 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
https://chromium.googlesource.com/chromium/src.git/+log/daa40f9aa676..0757a81a4083 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/73bc49ded0..0239463706 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7f20584b3b..72f4839ee3 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/874fd0e155..6d5ac0f7d3 * third_party/android_build_tools/lint/cipd: kKXCEgWultH2wInyOH7z6Fmhexd5eiDAUqbURsNalcgC..4MPZFuPDaatdMYFqJYta2HQNjSvpjM5fMXK1xtG-LGMC * third_party/android_build_tools/manifest_merger/cipd: KwSGMP0ESTSb86A6PF2-SVVtVJpfQqQwIzJdO1QCzf0C..LS9EZjWzw2n7RuYXAlSTw8D45XuB-a49GWwBzaLfsP0C * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0407d6b160..ec7d8f539c * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/a56e6191d5..ba19d93d6d * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/56152c7943..30d23eb814 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/19c4f7c825..ddf513ccae * third_party/r8/cipd: 5UvXlaJ_QJr1To4A-gAjc6QG4DJ6kATfIbnQdJrkZtwC..y-gKj5TCCHcid39xiew3e8_-eZpgmCf83D9J_-extpQC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/808ee5802f..5326cd6869 * third_party/siso/cipd: git_revision:28aaab3e02fc38229f8c10c77f4569d12ef3a1c3..git_revision:f78a1a934cf426488147ca8a4a17c29a010af8d5 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/8d3bf67ab0..93a7974ca0 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/1d6b7f00eb..8837640dd2 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/16429092be..e028ac6498 * tools/win: https://chromium.googlesource.com/chromium/src/tools/win/+log/2a9823716f..baacfc6d59 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I94c6e4a9e44dc1998ea593cf28202acb1a845808 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7515651 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/6ca88d8e0d9c..f55c0a8afef0 2026-01-22 mateusz.bahyrycz@cognizant.com Tests mandatory formats support for indirect copy 2026-01-22 rgarcia@igalia.com Test local invocation index with quad derivatives 2026-01-22 javed@igalia.com Add tests for remap to high locations 2026-01-22 piotr.byszewski@cognizant.com Generate code for shader_object.binary.device_features.* tests 2026-01-22 jbolz@nvidia.com Add random value testing to coopvec typeconvert tests. 2026-01-22 rgarcia@igalia.com Fix dEQP-VK.api.copy_and_blit.dynamic_state.* 2026-01-22 scerveau@igalia.com Add DEQP_DISABLE_VK_VIDEO_TESTS CMake option 2026-01-22 piotr.byszewski@cognizant.com Check requirements in checkSupport, part 5 (query_pool module) 2026-01-22 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.5 into vk-gl-cts/main 2026-01-22 mateusz.bahyrycz@cognizant.com Adds compute-only variant for ubo tests 2026-01-22 rgarcia@igalia.com Test DRLR in partial secondary command buffers 2026-01-22 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.13 into vk-gl-cts/main 2026-01-21 rgarcia@igalia.com Test DRLR color location remapping with blending 2026-01-21 scerveau@igalia.com video: Update Vulkan-Video-Samples to v0.3.9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I1cd58279aa008c5737a5092eb7f89281c6bd7ab4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7515652 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/cf6f449e02cd..10e26d62e399 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/bf07ce313f12be0069e3322c8b0462c0c8bf9bed..7e47ffa5e8647946a6ebc96f67cf974f6afaa8ba https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/fbe4f3ad913c44fe8700545f8ffe35d1382b7093..77a096c929cefa5069fcbf9060aac6a09bd88bd5 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/5d94bb4dcc968cccce1f601324fcaf3eda92a52b..b5c8f996196ba4aa6d8f97e52b5d3b6e70f7e4e2 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/cde39136de2fef536e915d6f002608e42a7409d7..32fcb949e253cbeb40cda7ea76122b492db579ae https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/5ebf9cb185ee2caf429a5e9b6fabb9a2b5fa8a1d..48a4bcbdf619e57204783f8c1a04c76c160ddd5b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/9a5001916ccc34f9d0facf084790e3778c70c3f8..a663eca87ba71294dd4b74ba9d3e64a72d725453 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/23f2b61bd62cd934043bbc77dfb47b150f839ef6..12ec709705c282b111163730e5534a9d956a1e91 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I238e0d7fe52dd877f70db68bbdaa7302d044c79a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7515653 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Remove ProvokingVertexComputePipelineDesc, it has undefined behavior in constructors and complexity in hashing. The provoking vertex compute functions are defined by the uint32_t that configures the function constants. Use that as the hash key. Fixed: angleproject:477879967 Change-Id: I15e7318c7a88a73f58bc308b861954e6dea2b665 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7511403 Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Adds the necessary builders using chromium-luci to test Linux/x64/Release/SwiftShader on CI and try. This includes a CQ builder for all Linux/x64/Release testing as well as a manual-only SwiftShader trybot, but the CQ builder is not actually added to CLs yet. This is intended to be functionally identical to the SwiftShader component of the existing linux-test builder. It is likely that some minor details got missed, but we should be able to iron those out once the CI builder is running. Bug: angleproject:475260235 Change-Id: I8d47bdc5ad7be0a7121ddcd20a3e7bd8d91e6139 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7511985 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
SixteenBppTextureTest.RGBA5551Validation/ES2_Vulkan after 535.183.01 Ubuntu 22.04 upgrade. Bug: angleproject:362486580 Change-Id: I38091180d9bccb927428ef8b136a4e33e9c45af0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7517108 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Simplify getting command encoders by removing redundant ContextMtl::endEncoding() calls from blit, compute encoder getters. Move the code from endRenderEncoding() into endEncoding(), as that is the only caller. Remove the redundant if (mBlitEncoder.valid()) call. Fixed: angleproject:477978589 Change-Id: Ib7a86c9a33879458a41088cffef0db9512c694af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7510878 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Keep constant array-returning expressions const when hoisted by SeparateExpressionsReturningArrays. Use EvqConst and share the constant value to avoid non-constant global initializers hitting HLSL asserts. Bug: angleproject:42264620 Change-Id: Ide7edec8320161b018280f50e35b8d470b63a80a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7508874 Auto-Submit: Aaron Teo <hocheung@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
FramebufferWgpu::startNewRenderPass() currently pulls the depth/stencil clear values from the gl state on every call, fix that. Bug: angleproject:474131922 Change-Id: I82e8b8ef03c88b1eeaa0f1d58793d3c1af42730d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7512342 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
https://chromium.googlesource.com/chromium/src.git/+log/0757a81a4083..e3a1e6f3ee5b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0239463706..5ef0c4e781 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4dc32b3f51..6a18683f55 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/72f4839ee3..5c4e0257bb * third_party/android_build_tools/lint/cipd: 4MPZFuPDaatdMYFqJYta2HQNjSvpjM5fMXK1xtG-LGMC..Ow8jpaRkHsJyhElyBOWWKBWl0KKNNuqbAE-cYWSPwQAC * third_party/android_build_tools/manifest_merger/cipd: LS9EZjWzw2n7RuYXAlSTw8D45XuB-a49GWwBzaLfsP0C..ITWXausfSUWr6lXywWULrkJidKFVjgOEGgVwcGV61LgC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f0bcc24b23..145e14f52f * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/30d23eb814..2a32a53cd5 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/5326cd6869..37133fcc2f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/837ddf8a78..b70509b238 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I81227147971a666c186052d32cbfa90358c13e04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7519746 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/f55c0a8afef0..9ef5ffd652cb 2026-01-26 piotr.byszewski@cognizant.com Add reporting for Roadmap 2026 support 2026-01-26 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.5 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I0075dac91b261c2497c67ead99e554b13e7b6aad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7519747 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/10e26d62e399..54fcc5faac16 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/77a096c929cefa5069fcbf9060aac6a09bd88bd5..d3f9ef117aab877b23a266b1e7542549ea70b817 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/12ec709705c282b111163730e5534a9d956a1e91..2d34d32c82f7f0a308f09973f8874f69f56a66ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I56b8ad6278998cdcfe784f466c82d8328ab8ccad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7520704 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
https://swiftshader.googlesource.com/SwiftShader.git/+log/b0c7e1fb76fc..374652a342e0 2026-01-26 swiftshader.regress@gmail.com Regres: Update test lists @ b0c7e1fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I5e51109bfb146441ab0de0968eda6b1184397095 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7520318 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
The spec disallows opaque types in the true and false expressions of the ternary operator. While it doesn't explicitly mention that structs with samplers follow the same rule, it's reasonable to assume that. Native drivers do not support this, and neither AST nor IR transformations handle it. This was expected all along to be disallowed, except a comment said it's unnecessary to check because structs are altogether disallowed with the ternary operator, which is not true with ESSL 300+. Bug: angleproject:40096378 Change-Id: Ie3471fb9b010ae09f7d106a257e1ce9a1015b1f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7518128 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges changes from the latest ANGLE version whilst preserving @ChristopherHX's changes.