Exclude 404 responses from rate-limit counter#272
Merged
runleveldev merged 2 commits intomainfrom Apr 1, 2026
Merged
Conversation
…icon requests from triggering early rate-limit Agent-Logs-Url: https://github.com/mieweb/opensource-server/sessions/3fa31644-1044-4dfe-aa2d-e111bc78b3f0 Co-authored-by: runleveldev <44057501+runleveldev@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix early rate-limit trigger for Safari icon requests
Exclude 404 responses from rate-limit counter
Apr 1, 2026
runleveldev
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safari auto-requests
/apple-touch-icon.png,/apple-touch-icon-precomposed.png, and/favicon.icoon every page load. These 404s were counted against the 10-failure-per-5-min rate limit, exhausting the budget before any real interaction and triggering 429s on legitimate requests.Change
Added
requestWasSuccessfulto theRateLimitconfig so 404s are treated as non-failures and skipped — only actionable errors (401, 403, 5xx, etc.) consume rate-limit budget.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
scarf.sh/home/REDACTED/work/_temp/ghcca-node/node/bin/node node ./report.js(dns block)If you need me to access, download, or install something from one of these locations, you can either: