fix: address 6 bugs found during code review#116
Open
Copilot wants to merge 2 commits into
Open
Conversation
Agent-Logs-Url: https://github.com/microsphere-projects/microsphere-spring-boot/sessions/0473e6c3-eaf6-440d-9472-f5a7442d5011 Co-authored-by: mercyblitz <533114+mercyblitz@users.noreply.github.com>
- ConfigurationPropertiesBeanContext.convertForProperty(): guard against null value and null conversionService to prevent NPE - ConfigurationPropertiesBeanContext.setProperty(): publish convertedNewValue instead of raw newValue in the change event - OriginTrackedConfigurationPropertyInitializer.initializePropertySources(): null-check result of createOriginTrackedPropertySource() before calling propertySources.replace() to avoid NPE on unsupported resource types - ListenableBindHandlerAdapter.onFailure(): always notify BindListeners on failure, whether the parent handler throws or returns a fallback value - OnceApplicationPreparedEventListener: register a ContextClosedEvent listener to remove context IDs from the static processed-context cache when the context closes, preventing both memory leaks and missed re-executions - ArtifactsCollisionDiagnosisListener.getArtifactsCollisionMap(): change return type to Map<String,List<Artifact>> so that all colliding artifacts (first occurrence + every duplicate) are tracked and logged; update test Agent-Logs-Url: https://github.com/microsphere-projects/microsphere-spring-boot/sessions/0473e6c3-eaf6-440d-9472-f5a7442d5011 Co-authored-by: mercyblitz <533114+mercyblitz@users.noreply.github.com>
|
Copilot created this pull request from a session on behalf of
mercyblitz
May 26, 2026 03:12
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigurationPropertiesBeanContext.convertForProperty()- NPE whenvalueorconversionServiceis nullConfigurationPropertiesBeanContext.setProperty()- publishes rawnewValueinstead ofconvertedNewValueOriginTrackedConfigurationPropertyInitializer.initializePropertySources()- null check beforereplace()ListenableBindHandlerAdapter.onFailure()- always notify listeners regardless of whether parent throwsOnceApplicationPreparedEventListener- clear static context-ID cache when context closesArtifactsCollisionDiagnosisListener.getArtifactsCollisionMap()- track all colliding artifacts (not just last duplicate)