Fix path for post-build template and adjust validation#7615
Fix path for post-build template and adjust validation#7615nohwnd merged 3 commits intomicrosoft:mainfrom
Conversation
- Fix backslash path to forward slash for template reference - Temporarily skip signing validation until infra issues are resolved, based on advice from Arcade. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nohwnd
force-pushed
the
fix-postbuild-template
branch
from
690c768 to
15ecc98
Compare
There was a problem hiding this comment.
Pull request overview
Updates the official Azure Pipelines definition to correctly reference the post-build template using a forward-slash path and disables signing validation as a temporary workaround for current infrastructure issues (per Arcade guidance).
Changes:
- Fix template include path formatting for the post-build template.
- Pass
enableSigningValidation: falseto temporarily skip signing validation in post-build.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| LclPackageId: 'LCL-JUNO-PROD-TESTFX' | ||
|
|
||
| - template: eng\common\templates-official\post-build\post-build.yml@self | ||
| - template: eng/common/templates-official/post-build/post-build.yml@self |
There was a problem hiding this comment.
Template includes in this pipeline generally use an absolute repo-root path (leading /), but this one is still relative (eng/common/...). To keep things consistent with the other template references in this file (and avoid any path-resolution ambiguity if the file is ever relocated), consider switching this to /eng/common/templates-official/post-build/post-build.yml@self.
| - template: eng/common/templates-official/post-build/post-build.yml@self | |
| - template: /eng/common/templates-official/post-build/post-build.yml@self |
| parameters: | ||
| # Temporarily disable signing validation until infra issues are resolved, based on advice from Arcade. | ||
| enableSigningValidation: False |
There was a problem hiding this comment.
Disabling signing validation on the official post-build stage is a significant safety/quality reduction. If this is truly temporary, please add a tracking link (issue/incident) and/or a clear re-enable mechanism (e.g., a pipeline parameter/variable toggle with a default of True) so we don’t accidentally ship long-term with signing validation turned off.
Same fix as microsoft/vstest#15592 — fix backslash path for post-build template reference and temporarily skip signing validation until infra issues are resolved, based on advice from Arcade.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com