Fix/sql schema exception handling#777
Closed
odaysec wants to merge 1 commit intomicrosoft:Developmentfrom
Closed
Conversation
…l_schema_plugin - Remove duplicate/unreachable except blocks - Move schema-building logic back into try block - Replace str(e) in user-facing response with generic message - Use debug_print() instead of print() for admin-controlled output - Keep detailed exception info in logs via log_event()
paullizer
reviewed
Mar 23, 2026
Contributor
paullizer
left a comment
paullizer
left a comment
There was a problem hiding this comment.
I appreciate noticing an improvement in our plugin. We rearchitected the plugin though and this request is no longer needed. I would appreciate your insight in the rest of our code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes/supersedes #726
Changes: