Skip to content

Update fixBootstrapToken.sh#240

Open
chrism9876 wants to merge 2 commits intomicrosoft:masterfrom
chrism9876:patch-1
Open

Update fixBootstrapToken.sh#240
chrism9876 wants to merge 2 commits intomicrosoft:masterfrom
chrism9876:patch-1

Conversation

@chrism9876
Copy link

These lines do nothing as the string "profiles status -type bootstraptoken" is being compared to "Bootstrap Token escrowed to server: NO" this will always be false. And why would you want to exit if token was not escrowed?

Removed early exit checks for escrow success and secure token validation.
@chrism9876
Copy link
Author

"$SECURE_TOKEN_STATUS" not declared no point doing comparrisons

@chrism9876
Copy link
Author

@microsoft-github-policy-service agree

@theneiljohnson
Copy link
Collaborator

Thanks for flagging the issue with $SECURE_TOKEN_STATUS not being declared — that's a valid observation. However, removing all the safety checks (bootstrap token escrow validation, secure token check, unknown user check) isn't the right fix. These guards prevent the script from blindly attempting token operations without validation.

A better approach would be to ensure $SECURE_TOKEN_STATUS is properly declared/populated before the checks run. Could you revise the PR to fix the variable declaration rather than removing the guard logic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants