Skip to content

vmm-tests: correctly request vhost dependency, update mapping#3261

Open
chris-oo wants to merge 1 commit intomicrosoft:mainfrom
chris-oo:vhost-artifact-fix
Open

vmm-tests: correctly request vhost dependency, update mapping#3261
chris-oo wants to merge 1 commit intomicrosoft:mainfrom
chris-oo:vhost-artifact-fix

Conversation

@chris-oo
Copy link
Copy Markdown
Member

This seemed to have been merged after another refactor, but this correctly expresses the dependency used by the vhost test.

@chris-oo chris-oo requested a review from a team as a code owner April 13, 2026 17:11
Copilot AI review requested due to automatic review settings April 13, 2026 17:11
smalis-msft
smalis-msft previously approved these changes Apr 13, 2026
@chris-oo chris-oo enabled auto-merge (squash) April 13, 2026 17:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the vmm vhost-user blk device test to request the OpenVMM vhost binary as an explicit artifact dependency and adjusts Flowey’s artifact→build mapping so the correct build is triggered.

Changes:

  • Add an OpenVMM vhost artifact dependency to the Linux-only vhost_user_blk_device test and use the resolved artifact path at runtime.
  • Update Flowey artifact selection mapping to request building openvmm_vhost when the corresponding Linux vhost artifacts are selected.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
vmm_tests/vmm_tests/tests/tests/multiarch.rs Switch vhost binary discovery from “known path” lookup to an explicit resolved artifact dependency passed via the test macro.
flowey/flowey_lib_hvlite/src/artifact_to_build_mapping.rs Map Linux vhost artifact selections to build.openvmm_vhost = true so the dependency is built.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants