vmm-tests: correctly request vhost dependency, update mapping#3261
Open
chris-oo wants to merge 1 commit intomicrosoft:mainfrom
Open
vmm-tests: correctly request vhost dependency, update mapping#3261chris-oo wants to merge 1 commit intomicrosoft:mainfrom
chris-oo wants to merge 1 commit intomicrosoft:mainfrom
Conversation
smalis-msft
previously approved these changes
Apr 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the vmm vhost-user blk device test to request the OpenVMM vhost binary as an explicit artifact dependency and adjusts Flowey’s artifact→build mapping so the correct build is triggered.
Changes:
- Add an OpenVMM vhost artifact dependency to the Linux-only
vhost_user_blk_devicetest and use the resolved artifact path at runtime. - Update Flowey artifact selection mapping to request building
openvmm_vhostwhen the corresponding Linux vhost artifacts are selected.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| vmm_tests/vmm_tests/tests/tests/multiarch.rs | Switch vhost binary discovery from “known path” lookup to an explicit resolved artifact dependency passed via the test macro. |
| flowey/flowey_lib_hvlite/src/artifact_to_build_mapping.rs | Map Linux vhost artifact selections to build.openvmm_vhost = true so the dependency is built. |
8c3fdcb to
5b168f5
Compare
smalis-msft
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seemed to have been merged after another refactor, but this correctly expresses the dependency used by the vhost test.